Fixing the typos and grammatical errors in Readme files #1246

mohitm15 · 2020-02-21T13:01:13Z

What kind of change does this PR introduce?

Bug Fix, fixes the issue #1245

If relevant, did you update the documentation?
Yes, Security.md and webpack-scaffold/readme.md

Summary
Fixing the typos and grammatical errors in Readme files

Does this PR introduce a breaking change?
No

Other information

jsf-clabot · 2020-02-21T13:01:15Z

All committers have signed the CLA.

ghost · 2020-02-21T13:01:19Z

There were the following issues with this Pull Request

Commit: 1c29100
- ✖ message may not be empty
- ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

webpack-bot · 2020-02-21T13:05:39Z

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

anshumanv

Your commit is not as expected, please commit using npm run commit or yarn commit

mohitm15 · 2020-02-21T13:36:31Z

I uses git commit -m (message) @anshumanv

Sent from my VIBE K6 Power using FastHub

anshumanv · 2020-02-21T13:38:03Z

We have specific commit guidelines which are most easily to adhere to using the commit helper package that we use, just do npm run commit and follow the prompt then you should be good.

jamesgeorge007 · 2020-02-21T13:42:00Z

packages/webpack-scaffold/README.md

@@ -86,7 +86,7 @@ this.configuration.myScaffold.webpackOptions.entry = createDynamicPromise(["app.

 Param: `String`

-Used to create an [assetFilterFunction](https://webpack.js.org/configuration/performance/#performance-assetfilter)
+Used to create a [assetFilterFunction](https://webpack.js.org/configuration/performance/#performance-assetfilter)


The former was fine.

See its readme context

The former was fine.

@mohitm15 you should be making the change here

Instead you made the change here:

Thanks for correcting @jamesgeorge007

snitin315 · 2020-02-21T13:42:39Z

packages/webpack-scaffold/README.md

@@ -86,7 +86,7 @@ this.configuration.myScaffold.webpackOptions.entry = createDynamicPromise(["app.

 Param: `String`

-Used to create an [assetFilterFunction](https://webpack.js.org/configuration/performance/#performance-assetfilter)


I think an is correct.

See above conversation, self-explanatory

anshumanv · 2020-02-21T13:42:41Z

Also please sign the CLA.

wizardofhogwarts

It seems to be that the change made is not what is pointed to in the screenshot shared. @mohitm15 You should revert the change you made and make the change where you shown in the screenshot. That's correct. @rishabh3112 is requested to review.

mohitm15 · 2020-02-22T09:57:18Z

We have specific commit guidelines which are most easily to adhere to using the commit helper package that we use, just do npm run commit and follow the prompt then you should be good.

Getting error logs while running it

anshumanv · 2020-02-22T09:58:32Z

Getting error logs while running it

What errors? Trace?

webpack-bot · 2020-02-22T09:58:47Z

@mohitm15 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@wizardofhogwarts Please review the new changes.

ghost · 2020-02-22T09:58:48Z

There were the following issues with this Pull Request

Commit: 1c29100
- ✖ message may not be empty
- ✖ type may not be empty
Commit: 73b12eb
- ✖ message may not be empty
- ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

mohitm15 · 2020-02-22T10:27:09Z

Getting error logs while running it

What errors? Trace?

anshumanv · 2020-02-22T11:46:03Z

Did you install the project dependencies?

ematipico · 2020-02-22T16:08:14Z

commit a command of our CLI :)

Maybe you wanted to do git commit

mohitm15 · 2020-02-23T06:03:12Z

Did you install the project dependencies?

NO , can you direct me to the link of project setup on local machine

anshumanv · 2020-02-23T06:23:33Z

@mohitm15 - https://github.com/webpack/webpack-cli/blob/next/.github/CONTRIBUTING.md

Read the Docs 😄

rishabh3112 · 2020-02-23T07:06:52Z

Thanks @mohitm15

mohitm15 · 2020-02-28T21:01:07Z

@mohitm15 - https://github.com/webpack/webpack-cli/blob/next/.github/CONTRIBUTING.md

Read the Docs

@anshumanv I am facing a problem regarding comminting the changes for my next PR. Can we have chat over gitter channel

anshumanv · 2020-02-29T04:27:11Z

@anshumanv I am facing a problem regarding comminting the changes for my next PR. Can we have chat over gitter channel

Sure we can, what's the problem exactly? Doing a discussion here will also help anyone who is having similar issues so I'd recommend doing it here.

mohitm15 · 2020-02-29T04:41:10Z

@anshumanv I am facing a problem regarding comminting the changes for my next PR. Can we have chat over gitter channel

Sure we can, what's the problem exactly? Doing a discussion here will also help anyone who is having similar issues so I'd recommend it doing here.

Sure

I had made changes in a separate branch for my latest issue, but after adding the changes using git add <filename> , I run git commit -m <message> but its not working, so I then tried yarn commit, but still causing error

anshumanv · 2020-02-29T04:42:57Z

I had made changes in a separate branch for my latest issue, but after adding the changes using git add , I run git commit -m but its not working, so I then tried yarn commit, but still causing error

What's the error? Are you sure you did yarn install?

mohitm15 · 2020-02-29T04:44:53Z

I had made changes in a separate branch for my latest issue, but after adding the changes using git add , I run git commit -m but its not working, so I then tried yarn commit, but still causing error

What's the error? Are you sure you did yarn install?

Yes

snitin315 · 2020-02-29T04:46:03Z

refer #1267 .

Make sure your branch is up-to-date with upstream and have this commit .

mohitm15 requested a review from a team as a code owner February 21, 2020 13:01

webpack-bot added PR: unreviewed PR: small labels Feb 21, 2020

webpack-bot added the PR: CI-ok label Feb 21, 2020

anshumanv requested changes Feb 21, 2020

View reviewed changes

webpack-bot added PR: reviewed-changes-requested and removed PR: unreviewed labels Feb 21, 2020

jamesgeorge007 reviewed Feb 21, 2020

View reviewed changes

snitin315 reviewed Feb 21, 2020

View reviewed changes

wizardofhogwarts suggested changes Feb 22, 2020

View reviewed changes

webpack-bot added PR: review-outdated and removed PR: reviewed-changes-requested labels Feb 22, 2020

ematipico previously approved these changes Feb 23, 2020

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels Feb 23, 2020

mohitm15 added 2 commits February 23, 2020 12:25

chore: fix grammatical errors

ef4ca0f

chore: fix typos

60ec6bf

rishabh3112 dismissed ematipico’s stale review via 60ec6bf February 23, 2020 07:00

webpack-bot added PR: review-outdated and removed PR: reviewed-approved labels Feb 23, 2020

rishabh3112 approved these changes Feb 23, 2020

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels Feb 23, 2020

rishabh3112 merged commit 52956a2 into webpack:next Feb 23, 2020

rishabh3112 mentioned this pull request Feb 23, 2020

Revise the readme files. #1245

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing the typos and grammatical errors in Readme files #1246

Fixing the typos and grammatical errors in Readme files #1246

mohitm15 commented Feb 21, 2020

jsf-clabot commented Feb 21, 2020 •

edited

Loading

ghost commented Feb 21, 2020

webpack-bot commented Feb 21, 2020

anshumanv left a comment

mohitm15 commented Feb 21, 2020 •

edited

Loading

anshumanv commented Feb 21, 2020

jamesgeorge007 Feb 21, 2020

mohitm15 Feb 22, 2020

jamesgeorge007 Feb 22, 2020

jamesgeorge007 Feb 22, 2020

mohitm15 Feb 22, 2020

snitin315 Feb 21, 2020

mohitm15 Feb 22, 2020 •

edited

Loading

anshumanv commented Feb 21, 2020

wizardofhogwarts left a comment

mohitm15 commented Feb 22, 2020

anshumanv commented Feb 22, 2020

webpack-bot commented Feb 22, 2020

ghost commented Feb 22, 2020

mohitm15 commented Feb 22, 2020

anshumanv commented Feb 22, 2020

ematipico commented Feb 22, 2020

mohitm15 commented Feb 23, 2020 •

edited

Loading

anshumanv commented Feb 23, 2020

rishabh3112 commented Feb 23, 2020

mohitm15 commented Feb 28, 2020

anshumanv commented Feb 29, 2020 •

edited

Loading

mohitm15 commented Feb 29, 2020

anshumanv commented Feb 29, 2020

mohitm15 commented Feb 29, 2020

snitin315 commented Feb 29, 2020 •

edited

Loading

		@@ -86,7 +86,7 @@ this.configuration.myScaffold.webpackOptions.entry = createDynamicPromise(["app.

		Param: `String`

		Used to create an [assetFilterFunction](https://webpack.js.org/configuration/performance/#performance-assetfilter)

Fixing the typos and grammatical errors in Readme files #1246

Fixing the typos and grammatical errors in Readme files #1246

Conversation

mohitm15 commented Feb 21, 2020

jsf-clabot commented Feb 21, 2020 • edited Loading

ghost commented Feb 21, 2020

webpack-bot commented Feb 21, 2020

anshumanv left a comment

Choose a reason for hiding this comment

mohitm15 commented Feb 21, 2020 • edited Loading

anshumanv commented Feb 21, 2020

jamesgeorge007 Feb 21, 2020

Choose a reason for hiding this comment

mohitm15 Feb 22, 2020

Choose a reason for hiding this comment

jamesgeorge007 Feb 22, 2020

Choose a reason for hiding this comment

jamesgeorge007 Feb 22, 2020

Choose a reason for hiding this comment

mohitm15 Feb 22, 2020

Choose a reason for hiding this comment

snitin315 Feb 21, 2020

Choose a reason for hiding this comment

mohitm15 Feb 22, 2020 • edited Loading

Choose a reason for hiding this comment

anshumanv commented Feb 21, 2020

wizardofhogwarts left a comment

Choose a reason for hiding this comment

mohitm15 commented Feb 22, 2020

anshumanv commented Feb 22, 2020

webpack-bot commented Feb 22, 2020

ghost commented Feb 22, 2020

mohitm15 commented Feb 22, 2020

anshumanv commented Feb 22, 2020

ematipico commented Feb 22, 2020

mohitm15 commented Feb 23, 2020 • edited Loading

anshumanv commented Feb 23, 2020

rishabh3112 commented Feb 23, 2020

mohitm15 commented Feb 28, 2020

anshumanv commented Feb 29, 2020 • edited Loading

mohitm15 commented Feb 29, 2020

anshumanv commented Feb 29, 2020

mohitm15 commented Feb 29, 2020

snitin315 commented Feb 29, 2020 • edited Loading

jsf-clabot commented Feb 21, 2020 •

edited

Loading

mohitm15 commented Feb 21, 2020 •

edited

Loading

mohitm15 Feb 22, 2020 •

edited

Loading

mohitm15 commented Feb 23, 2020 •

edited

Loading

anshumanv commented Feb 29, 2020 •

edited

Loading

snitin315 commented Feb 29, 2020 •

edited

Loading