tests(generator): enhance init generator tests #1236

anshumanv · 2020-02-17T05:26:59Z

enhance init generator tests

What kind of change does this PR introduce?
tests

Did you add tests for your changes?
Yay

If relevant, did you update the documentation?
NA

Summary

Added file and content checks in the generated files in init generator, missed that in my old PR.

Does this PR introduce a breaking change?
No

Other information

webpack-bot · 2020-02-17T05:31:38Z

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

packages/generators/__tests__/init-generator.test.ts

ematipico

Your test is failing. Check the logs.

ematipico · 2020-02-17T15:56:23Z

packages/generators/__tests__/init-generator.test.ts

@@ -1,7 +1,7 @@
 import { join } from 'path';
 import { run } from 'yeoman-test';
+const assert = require('yeoman-assert');


Use the import. You are under TypeScript here

Tried it but it wasn't working with this package. :(

That's probably because you didn't install the types

ematipico · 2020-02-17T15:56:53Z

packages/generators/__tests__/init-generator.test.ts

@@ -1,7 +1,7 @@
 import { join } from 'path';


You should install also @types/yeoman-assert

Right, will make the changes, good catch. 👍

ematipico · 2020-02-17T15:59:27Z

packages/generators/__tests__/init-generator.test.ts

+
+        // Check that all the project files are generated with the correct name
+        const filePaths = ['package.json', 'README.md', 'src/index2.js'];
+        assert.file([...filePaths.map(file => join(outputDir, file))]);


I had to skip the other tests that I merged because they were failing. You should use the jest assertion in order to tell to jest that is working. Or checking yeoman-assert documentation to understand how to integrate it with jest

Okay, sounds fair, will take a look. 👍

Is it a problem with yeoman-assert? I can't seem to find a way to integrate them with jest and the docs are really minimal.

Triggered travis on next again and it seems to pass now. 😟🤔

Check the logs locally while you test them (maybe run that single test). There are errors and jest can't recognize any assertion so it's like the test is empty

At this point do not use yeoman-assert and stick with the normal expect

Check the logs locally while you test them (maybe run that single test). There are errors and jest can't recognize any assertion so it's like the test is empty

I just ran a test which was supposed to fail in yeoman-assert and jest caught it, I think the errors from yeoman-assert are caught by jest on exit.

ematipico · 2020-02-17T16:02:28Z

This is from the logs

PASS packages/generators/__tests__/loader-generator.test.ts (5.522s)
npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path /tmp/f9ff699a773feb35ce68ffe10cd55974e6943e1c/my-webpack-plugin/package.json
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, open '/tmp/f9ff699a773feb35ce68ffe10cd55974e6943e1c/my-webpack-plugin/package.json'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2020-02-17T09_25_15_716Z-debug.log

ℹ INFO  For more information and a detailed description of each question, have a look at: https://github.com/webpack/webpack-cli/blob/master/INIT.md
ℹ INFO  Alternatively, run "webpack(-cli) --help" for usage info

npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path /tmp/166db8056f244410d75c82f0f8f7e83bcb726108/my-loader/package.json
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, open '/tmp/166db8056f244410d75c82f0f8f7e83bcb726108/my-loader/package.json'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2020-02-17T09_25_16_276Z-debug.log

anshumanv · 2020-02-17T16:07:40Z

This is from the logs

Thanks! I wonder how it's failing now when it was fine before. Unusual. Anyways, will take a look. 👍

anshumanv · 2020-02-17T16:20:28Z

Why is snyk failing? Does anybody have any ideas around it? And what packages is it failing for?

ematipico · 2020-02-17T18:27:13Z

I merged the PR where we moved the main cli under lerna. Also, we switched to yarn. You should use that now :)

anshumanv · 2020-02-17T18:29:24Z

I merged the PR where we moved the main cli under lerna. Also, we switched to yarn. You should use that now :)

Thanks for the heads up! Will rebase and do the changes in a while. Thanks!

enhance init generator tests

fix docs typo

use join

ematipico

Is the assertion now working?

webpack-bot · 2020-02-23T07:29:01Z

@rishabh3112 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ematipico Please review the new changes.

rishabh3112 · 2020-02-23T07:37:41Z

Thanks!

anshumanv · 2020-02-23T07:38:30Z

Thanks for the rebase! 😄

anshumanv requested a review from a team as a code owner February 17, 2020 05:26

webpack-bot added the PR: unreviewed label Feb 17, 2020

webpack-bot added the PR: CI-ok label Feb 17, 2020

jamesgeorge007 requested changes Feb 17, 2020

View reviewed changes

packages/generators/__tests__/init-generator.test.ts Outdated Show resolved Hide resolved

webpack-bot added PR: reviewed-changes-requested and removed PR: unreviewed labels Feb 17, 2020

ematipico previously approved these changes Feb 17, 2020

View reviewed changes

webpack-bot added the PR: reviewed-approved label Feb 17, 2020

anshumanv dismissed ematipico’s stale review via 8e50a03 February 17, 2020 09:20

webpack-bot added PR: review-outdated and removed PR: reviewed-approved PR: reviewed-changes-requested labels Feb 17, 2020

jamesgeorge007 previously approved these changes Feb 17, 2020

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels Feb 17, 2020

rishabh3112 previously approved these changes Feb 17, 2020

View reviewed changes

ematipico suggested changes Feb 17, 2020

View reviewed changes

webpack-bot added the PR: reviewed-changes-requested label Feb 17, 2020

ematipico suggested changes Feb 17, 2020

View reviewed changes

anshumanv closed this Feb 17, 2020

anshumanv reopened this Feb 17, 2020

wizardofhogwarts previously approved these changes Feb 19, 2020

View reviewed changes

anshumanv added 2 commits February 22, 2020 20:21

tests(generator): enahnce init generator tests

27a8e11

enhance init generator tests

tests(generator): fix docs typo

66de5a5

fix docs typo

anshumanv added 3 commits February 22, 2020 20:23

tests(init-gen): fix import in init-gen

681b47b

tests(test): use join in tests

609c812

use join

tests(tests): add types for yeoman-assert

a402d96

anshumanv dismissed stale reviews from wizardofhogwarts, rishabh3112, and jamesgeorge007 via a402d96 February 22, 2020 15:19

anshumanv force-pushed the test/init-gen branch from 8e50a03 to a402d96 Compare February 22, 2020 15:19

webpack-bot added PR: review-outdated and removed PR: reviewed-approved PR: reviewed-changes-requested labels Feb 22, 2020

ematipico reviewed Feb 22, 2020

View reviewed changes

ematipico approved these changes Feb 22, 2020

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels Feb 22, 2020

rishabh3112 changed the title ~~tests(generator): enahnce init generator tests~~ tests(generator): enhance init generator tests Feb 23, 2020

chore: rebase

41e45ae

webpack-bot added PR: review-outdated and removed PR: reviewed-approved labels Feb 23, 2020

anshumanv requested a review from rishabh3112 February 23, 2020 07:36

rishabh3112 approved these changes Feb 23, 2020

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels Feb 23, 2020

rishabh3112 merged commit 2c1e34c into webpack:next Feb 23, 2020

anshumanv deleted the test/init-gen branch February 23, 2020 07:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests(generator): enhance init generator tests #1236

tests(generator): enhance init generator tests #1236

anshumanv commented Feb 17, 2020

webpack-bot commented Feb 17, 2020

ematipico left a comment

ematipico Feb 17, 2020

anshumanv Feb 17, 2020

ematipico Feb 17, 2020

ematipico Feb 17, 2020

anshumanv Feb 17, 2020

ematipico Feb 17, 2020 •

edited

Loading

anshumanv Feb 17, 2020

anshumanv Feb 17, 2020

anshumanv Feb 17, 2020

ematipico Feb 17, 2020

ematipico Feb 17, 2020

anshumanv Feb 22, 2020

ematipico commented Feb 17, 2020

anshumanv commented Feb 17, 2020

anshumanv commented Feb 17, 2020

ematipico commented Feb 17, 2020

anshumanv commented Feb 17, 2020

ematipico left a comment

webpack-bot commented Feb 23, 2020

rishabh3112 commented Feb 23, 2020

anshumanv commented Feb 23, 2020

tests(generator): enhance init generator tests #1236

tests(generator): enhance init generator tests #1236

Conversation

anshumanv commented Feb 17, 2020

webpack-bot commented Feb 17, 2020

ematipico left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ematipico Feb 17, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ematipico commented Feb 17, 2020

anshumanv commented Feb 17, 2020

anshumanv commented Feb 17, 2020

ematipico commented Feb 17, 2020

anshumanv commented Feb 17, 2020

ematipico left a comment

Choose a reason for hiding this comment

webpack-bot commented Feb 23, 2020

rishabh3112 commented Feb 23, 2020

anshumanv commented Feb 23, 2020

ematipico Feb 17, 2020 •

edited

Loading