ci: add Node.js v20 (#3739)

webpack · Jun 1, 2023 · 1e9e946 · 1e9e946
1 parent 79b0f31
commit 1e9e946
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 5 deletions.
diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml
@@ -66,7 +66,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest, macos-latest]
-        node-version: [14.x, 16.x, 18.x, 19.x]
+        node-version: [14.x, 16.x, 18.x, 20.x]
         shard: ["1/4", "2/4", "3/4", "4/4"]
         webpack-version: [latest]
         dev-server-version: [latest]

diff --git a/package.json b/package.json
@@ -88,7 +88,7 @@
     "style-loader": "^3.3.1",
     "ts-jest": "^29.0.1",
     "ts-loader": "^9.3.1",
-    "ts-node": "^10.8.0",
+    "ts-node": "^10.9.1",
     "typescript": "^5.0.4",
     "webpack": "^5.72.0",
     "webpack-bundle-analyzer": "^4.5.0",

diff --git a/test/build/config-format/typescript-esnext/package.json b/test/build/config-format/typescript-esnext/package.json
@@ -1,3 +1,6 @@
 {
-  "type": "module"
+  "type": "module",
+  "engines": {
+    "node": ">=14.15.0"
+  }
 }
diff --git a/test/build/config-format/typescript-esnext/typescript.test.js b/test/build/config-format/typescript-esnext/typescript.test.js
@@ -13,9 +13,18 @@ describe("webpack cli", () => {
       return;
     }
 
+    const env = { ...process.env };
+
+    if (majorNodeVersion >= 20) {
+      // Node.js 20+ change logic, so we need to force esm config loading for test purposes
+      env.WEBPACK_CLI_FORCE_LOAD_ESM_CONFIG = true;
+    }
+
     const { exitCode, stderr, stdout } = await run(__dirname, ["-c", "./webpack.config.ts"], {
-      nodeOptions: ["--loader=ts-node/esm"],
+      nodeOptions: ["--experimental-loader=ts-node/esm"],
+      env,
     });
+
     expect(stderr).not.toBeFalsy(); // Deprecation warning logs on stderr
     expect(stdout).toBeTruthy();
     expect(exitCode).toBe(0);

diff --git a/yarn.lock b/yarn.lock
@@ -9700,7 +9700,7 @@ ts-loader@^9.3.1:
     micromatch "^4.0.0"
     semver "^7.3.4"
 
-ts-node@^10.8.0, ts-node@^10.8.1:
+ts-node@^10.8.1, ts-node@^10.9.1:
   version "10.9.1"
   resolved "https://registry.yarnpkg.com/ts-node/-/ts-node-10.9.1.tgz#e73de9102958af9e1f0b168a6ff320e25adcff4b"
   integrity sha512-NtVysVPkxxrwFGUUxGYhfux8k78pQB3JqYBXlLRZgdGUqTO5wU/UyHop5p70iEbGhB7q5KmiZiU0Y3KlJrScEw==