Hide tooltip when hovering over the attribution group and between top level groups. #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-level groups. (cherry picked from commit 93e98aa)
Member
|
Thanks! Would you be able to showcase the difference in behavior with a small screencap or something? It would make it easier to understand how this behavior has changed now |
Contributor
Author
|
Before: tooltips-before.mp4After: tooltip-after.mp4 |
Member
|
Nice, thank you! Looks great! Would you be able to write a small note on the changelog about this? |
valscion
reviewed
Jan 20, 2021
| // Ignoring hovering on `FoamTree` branding group and the root group | ||
| if (event.group && (event.group.attribution || event.group === this.get('dataObject'))) { | ||
| event.preventDefault(); | ||
| if (props.onMouseLeave) { |
Member
There was a problem hiding this comment.
Do we need this conditional? Is there a place in the code where props.onMouseLeave would not be specified?
Contributor
Author
There was a problem hiding this comment.
I made the condition analogous to the props.onGroupHover check below, which is also there but probably not required:
if (props.onGroupHover) {
props.onGroupHover.call(component, event);
}
I can remove the props.onMouseLeave condition, not a problem.
th0r
approved these changes
Jan 20, 2021
Collaborator
|
Thanks! |
This was referenced Mar 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.