Skip to content

Add leading zero to hour & minute on <title /> when needed #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valscion merged 9 commits into from
Oct 17, 2019
Merged

Add leading zero to hour & minute on <title /> when needed #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0ea734d
Add leading zero to hour & minute on getCurrentTime() & use substr(-2…
mhxbe Sep 22, 2019
49623c9
Use .slice() in favor of soon to be deprecated .slice()
mhxbe Sep 22, 2019
27b2de0
Use .slice() in favor of soon to be deprecated .substr()
mhxbe Sep 22, 2019
5219462
Merge branch 'bugfix/page-title-hours-minutes' of github.com:mhxbe/we…
mhxbe Sep 22, 2019
f04ab3e
Use .padStart(2,0) to prefix one-digit numbers with zero
mhxbe Sep 22, 2019
4b58fae
Revert .padStart to .slice since padStart is not supported in Node v6
mhxbe Oct 17, 2019
f614bd1
Update CHANGELOG.md
valscion Oct 17, 2019
3faca9d
Merge branch 'master' into bugfix/page-title-hours-minutes
valscion Oct 17, 2019
2596783
Consolidate changelog whitespace
valscion Oct 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ _Note: Gaps between patch versions are faulty, broken or test releases._

<!-- Add changelog entries for new changes under this section -->

* **Bug Fix**
* Add leading zero to hour & minute on `<title />` when needed ([#314](https://github.com/webpack-contrib/webpack-bundle-analyzer/pull/314) by [@mhxbe](https://github.com/mhxbe))

## 3.6.0

* **Improvement**
Expand Down
4 changes: 2 additions & 2 deletions src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ exports.getCurrentTime = function () {
const year = time.getFullYear();
const month = MONTHS[time.getMonth()];
const day = time.getDate();
const hour = time.getHours();
const minute = time.getMinutes();
const hour = `0${time.getHours()}`.slice(-2);
const minute = `0${time.getMinutes()}`.slice(-2);
return `${day} ${month} ${year} at ${hour}:${minute}`;
};