You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Do we have already formatted message? As you can see in this PR we duplicate logic for message formatting from dart-sass (if I missed something please tell me), but honestly I didn't want to do this at all, will be great if logger interface has formattedMessage (maybe better name) or something similar, so we would just like to use it:
2. Do we have already formatted message? As you can see in this PR we duplicate logic for message formatting from dart-sass (if I missed something please tell me), but honestly I didn't want to do this at all, will be great if logger interface has formattedMessage (maybe better name) or something similar, so we would just like to use it:
We could add this. Do you want to submit a proposal for this to the Sass language repo?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Use webpack logger, so developer can see logs in stats
Breaking Changes
No
Additional Info
@nex3 Hello, I found couple problems with logger interface:
dart-sass(if I missed something please tell me), but honestly I didn't want to do this at all, will be great if logger interface hasformattedMessage(maybe better name) or something similar, so we would just like to use it: