Allow passing functions option as function
#651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lunelson
changed the title
functions option as function
lunelson
force-pushed
the
functions-function
branch
from
53b60cb to
f4ac3db
Compare
Codecov Report
@@ Coverage Diff @@
## master #651 +/- ##
==========================================
+ Coverage 98% 98.02% +0.02%
==========================================
Files 6 6
Lines 150 152 +2
==========================================
+ Hits 147 149 +2
Misses 3 3
Continue to review full report at Codecov.
|
Allows the `functions` option for node-sass or dart-sass to be a function, in which case it will be passed the Loader Context as argument
Adds a test for the case where the functions option is supplied as a function. Passes the Loader Context and also checks that it is available.
lunelson
force-pushed
the
functions-function
branch
from
f4ac3db to
fc6c195
Compare
Contributor
Author
|
I've tried to follow all the guidelines but I don't know how to make the travis build pass here, it's failing with "Invalid revision range" |
alexander-akait
approved these changes
Dec 17, 2018
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Strange error on CI, don't worry looks good, we will release this in next version, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
This PR adds support for supplying the
functionsoption as a function of the Loader Context. This corresponds to part of the issue I filed here.Breaking Changes
None. Added a test similar to the one for the "
dataas function"; it passes.