Report error to user for problems loading node-sass#562
Merged
jhnns merged 2 commits intowebpack:masterfrom Apr 24, 2018
Merged
Report error to user for problems loading node-sass#562jhnns merged 2 commits intowebpack:masterfrom
jhnns merged 2 commits intowebpack:masterfrom
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #562 +/- ##
=======================================
Coverage 97.58% 97.58%
=======================================
Files 6 6
Lines 124 124
=======================================
Hits 121 121
Misses 3 3
Continue to review full report at Codecov.
|
Member
|
/cc @jhnns |
Member
|
Awesome 👍 this makes totally sense and sorry for hiding the original error. |
|
When will this change be released? |
Member
|
in 7 version |
|
In v7.0.1 it is not fixed: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #561
This provides the full error instead of:
sass-loader` requires `node-sass` >=4. Please install a compatible version..When I had the wrong node-sass binding for my version of Linux I get the following with this PR:
Which directed me to the actual problem.