Skip to content

Pr/origin/395 #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhnns merged 2 commits into from
Mar 7, 2017
Merged

Pr/origin/395 #398

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
911a774
add comment as content string fallback
lukeed Mar 7, 2017
462ae5f
Improve check for empty content
jhnns Mar 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,12 @@ function sassLoader(content) {
addNormalizedDependency
));

// Skip empty files, otherwise it will stop webpack, see issue #21
if (options.data.trim() === "") {
callback(null, "");
Copy link
Contributor

@michael-ciniawsky michael-ciniawsky Mar 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

if (options.data.trim() === "") return callback(null, "");

? 🙃

Copy link
Member Author

@jhnns jhnns Mar 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noooo, I don't like that style (and my global eslint complains about inconsistent return values) 😁

Copy link
Contributor

@michael-ciniawsky michael-ciniawsky Mar 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

return;
}

// start the actual rendering
asyncSassJobQueue.push(options, (err, result) => {
if (err) {
Expand Down