Skip to content

Add Comment as content default#395

Closed
lukeed wants to merge 1 commit intowebpack:masterfrom
lukeed:patch-1
Closed

Add Comment as content default#395
lukeed wants to merge 1 commit intowebpack:masterfrom
lukeed:patch-1

Conversation

@lukeed
Copy link
Contributor

@lukeed lukeed commented Mar 7, 2017

Without it, an empty file will throw the following error:

Module build failed: No input specified: provide a file name or a source string to process

In my case, I'm loading third-party components which always include an accompanying .css file, but aren't all populated.

By adding a comment as a (harmless) fallback, empty files are easily "ignored".

@jsf-clabot
Copy link

jsf-clabot commented Mar 7, 2017

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Mar 7, 2017

Coverage Status

Changes Unknown when pulling 911a774 on lukeed:patch-1 into ** on webpack-contrib:master**.

@jhnns jhnns mentioned this pull request Mar 7, 2017
@jhnns jhnns closed this in #398 Mar 7, 2017
@jhnns
Copy link
Member

jhnns commented Mar 7, 2017

Thanks for the work. This commit was pulled in with #398 👍

@lukeed
Copy link
Contributor Author

lukeed commented Mar 7, 2017

Thanks~

@lukeed lukeed deleted the patch-1 branch March 7, 2017 23:28
jhnns added a commit that referenced this pull request Mar 7, 2017
Prevents regressions like #395

#21
@jhnns jhnns mentioned this pull request Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants