Skip to content

Conversation

@hedgepigdaniel
Copy link

This isn't a good long term solution but it fixes the problem and allows sass files to be compiled properly (if more slowly) by webpack until the bug in node-sass is fixed.

@hedgepigdaniel
Copy link
Author

Fixes #100 #99

@matt-d-rat
Copy link

All be it a temporary solution, I definitely need this soon.

@patrickhaug
Copy link

How and where in webpack should I use renderSync?

@hedgepigdaniel
Copy link
Author

If you'd like to try my fork with these fixes, you can do npm install github.com:OpenLearningNet/sass-loader.git --save. That means instead of using the main branch of sass-loader you use my branch which is the source of this pull request. Otherwise if this or another fix gets merged you can go back to jtangelder's branch.

@snario
Copy link

snario commented Jul 15, 2015

@hedgepigdaniel tried your solution but it only delays the hanging from 40% to 61% for me, so not a complete fix unfortunately

@jhnns
Copy link
Member

jhnns commented Jul 22, 2015

Mhmmm ... do you know how deasync works? I'm a bit afraid to merge this when deasync is messing with node's event loop. It looks like black magic to me 😀

Can more people try this PR locally? If it fixes the current issues (and deasync is "harmless"), I am willing to merge it.

@jhnns
Copy link
Member

jhnns commented Aug 5, 2015

Issue fixed by #132.

But thank you for your effort and your proposal 👍. Although I did not merge it, I do think that these contributions help to improve the code.

@jhnns jhnns closed this Aug 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants