fix: add support for node-sass 7#1072
Merged
alexander-akait merged 1 commit intowebpack:v10from Jul 1, 2022
julienma:fix-node-sass-7
Merged
fix: add support for node-sass 7#1072alexander-akait merged 1 commit intowebpack:v10from julienma:fix-node-sass-7
alexander-akait merged 1 commit intowebpack:v10from
julienma:fix-node-sass-7
Conversation
|
|
Author
|
@snitin315 CLA done. |
Author
|
Note: I made the PR against branch |
snitin315
suggested changes
Jul 1, 2022
Member
snitin315
left a comment
There was a problem hiding this comment.
Is this not working with the latest version v13 as well?
Author
|
Don't know, I'm stuck on v10 due to other deps (mainly webpack 4). |
alexander-akait
approved these changes
Jul 1, 2022
Author
|
Thanks! I'll wait for the new release :) |
Author
|
Hey @alexander-akait, just to get a feeling of the timing, do you have an idea of when a new release including this PR will be cut? Thanks! |
Member
|
@julienma Hello, sorry for delay, today |
Author
|
@alexander-akait great, waiting for it :) Thank you! |
Author
|
Thanks for the release! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
#1002 was incomplete (I guess? because it wasn't working for me, and with this change it does).
With:
Got error:
Breaking Changes
Additional Info