This repository has been archived by the owner on Aug 15, 2024. It is now read-only.
Update events to v3 #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matches the Node 8 API. v1 matched Node 4, and some new methods have since been introduced (notably `prepend[Once]Listener`). The major bump in `events` was because: - There is a breaking change in the `listeners()` method regarding `once()` listeners nodejs/node#6881 I think it's super unlikely to affect anyone, but there you go. - The gzipped size almost doubled from 1.1KB to 2.1KB. It'll shrink a bit because some patches have since landed in Node that remove some code, but it'll still be bigger than it was because of the new methods. Deets: https://github.com/Gozala/events/releases/tag/v2.0.0
|
|
|
Updated to events v3, which matches the Node 10 API, including the new |
|
How is this coming along? Any updates? |
|
I would really like to see this one merged 😄 |
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matches the Node 10 API. v1 matched Node 4, and some new methods have
since been introduced (notably
prepend[Once]Listener). v2 matchedNode 8, but since then Node 10 has added
.off().The major bump to v2 was because:
listeners()method regardingonce()listeners events: unwrap #once listeners in #listeners nodejs/node#6881I think it's super unlikely to affect anyone, but there you go.
bit in future releases because some patches have since landed in
Node that remove some code, but it'll still be bigger than it was
because of the new methods.
The major bump to v3 was because:
.off()method is a common name that could cause collisionswith userland implmentations if users modified the EventEmitter
prototype. This again is unlikely to hurt anyone, because even if they
did define their own
.off()on the EventEmitter prototype, it would99% certainly be doing the same thing.
Deets:
https://github.com/Gozala/events/releases/tag/v2.0.0
https://github.com/Gozala/events/releases/tag/v3.0.0