This repository was archived by the owner on Dec 17, 2025. It is now read-only.
Export parseQuery (#76) #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `exports.parseQuery` in `lib/index.js` - Separate `test/parseQuery.test.js` from `test/getOptions.test.js` - Add `parseQuery` in `README.md`
|
|
jhnns
suggested changes
Mar 15, 2017
Member
jhnns
left a comment
jhnns
left a comment
There was a problem hiding this comment.
Awesome 👍
There are only three small nitpicks, sorry :). After that, we're good to go.
test/getOptions.test.js
Outdated
| test.expected | ||
| ); | ||
| }); | ||
| describe("when loaderContext.query is a string that has length", () => { |
Member
There was a problem hiding this comment.
I'd write ... is a string with length > 0
README.md
Outdated
| Parses a passed string (e.g. `loaderContext.resourceQuery`) as a query string, and returns an object. | ||
|
|
||
| ``` javascript | ||
| var params = loaderUtils.parseQuery(this.resourceQuery); // resource: `file?param1=foo` |
Member
There was a problem hiding this comment.
Please use const in the README if the value is not changed
README.md
Outdated
|
|
||
| ``` javascript | ||
| var params = loaderUtils.parseQuery(this.resourceQuery); // resource: `file?param1=foo` | ||
| if (params.param1 === 'foo') { |
Contributor
Author
|
I did not change other |
Member
|
Oh, that would be great. Didn't realize we already have this inconsistency 😁 |
Contributor
Author
|
Ok, I replaced those with |
Member
|
Published as |
Contributor
Author
|
Thank you 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exports.parseQueryinlib/index.jstest/parseQuery.test.jsfromtest/getOptions.test.jsparseQueryinREADME.md