Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitattributes for normalizing end of lines #204

Merged

Conversation

peter-spireng
Copy link
Contributor

As Prettier default expect "lf" on line endings, we need to normalize them with gitattributes - fixes #203

@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #204 (85aee62) into master (a282654) will not change coverage.
The diff coverage is n/a.

❗ Current head 85aee62 differs from pull request most recent head 91a4dd1. Consider uploading reports for the commit 91a4dd1 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #204   +/-   ##
=======================================
  Coverage   76.66%   76.66%           
=======================================
  Files          10       10           
  Lines         360      360           
  Branches      112      112           
=======================================
  Hits          276      276           
  Misses         73       73           
  Partials       11       11           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a282654...91a4dd1. Read the comment docs.

@alexander-akait
Copy link
Member

Can you regenerate lock file to fix security problem?

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 29, 2022

CLA Signed

The committers are authorized under a signed CLA.

@peter-spireng
Copy link
Contributor Author

Lock file regenerated

@alexander-akait
Copy link
Member

Can you accept CLA?

@peter-spireng
Copy link
Contributor Author

Done, also fixed commit message because of commitlint. Hopefully, it is all...

@peter-spireng
Copy link
Contributor Author

@alexander-akait can you please aprove workflow?

@alexander-akait alexander-akait merged commit 9fe2381 into webpack:master Feb 3, 2022
@alexander-akait
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prettier show all files with error because of default
2 participants