Skip to content

Conversation

@jhnns
Copy link
Member

@jhnns jhnns commented Mar 16, 2017

No description provided.

jhnns added 2 commits March 16, 2017 18:42
* Remove sourceMappingURL from generated CSS since the less-loader does not know the final location of the source map
* Pass source map as object to the next loader

BREAKING CHANGE:

Since the map is now passed as an object to the next loader, this could potentially break if another loader than the css-loader is used. The css-loader accepts both.
@jhnns jhnns merged commit 55f347a into master Mar 16, 2017
@jhnns jhnns deleted the fix/source-maps branch March 16, 2017 17:57
@codecov
Copy link

codecov bot commented Mar 16, 2017

Codecov Report

Merging #163 into master will increase coverage by 2.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
+ Coverage   93.22%   95.23%   +2.01%     
==========================================
  Files           2        3       +1     
  Lines          59       63       +4     
  Branches        9        6       -3     
==========================================
+ Hits           55       60       +5     
+ Misses          4        3       -1
Impacted Files Coverage Δ
src/removeSourceMappingUrl.js 100% <100%> (ø)
src/index.js 94.54% <100%> (+1.81%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 249e7fd...895044f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants