Skip to content

Fix invalid syntax in code sample #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
treyhuffine wants to merge 3 commits into from
Closed

Fix invalid syntax in code sample #142

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bf1ba9
Fix invalid syntax in code sample
treyhuffine Jan 27, 2017
869b2b5
Fix unsupported syntax for "loader"
treyhuffine Jan 27, 2017
bf42ba2
Update to newest version of ExtractTextPlugin
treyhuffine Mar 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,9 @@ module.exports = {
rules: [
{
test: /\.less$/,
use: ExtractTextPlugin.extract(
use: ExtractTextPlugin.extract({

@renatobenks-zz renatobenks-zz Jan 29, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this issue was fixed on my pr #140, look!!

@treyhuffine treyhuffine Jan 30, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at #127 then.

@renatobenks-zz renatobenks-zz Jan 30, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my!!! This is need be update

fallbackLoader: 'style-loader',
loaders: [
loader: [

@renatobenks-zz renatobenks-zz Jan 29, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man, this is acceptable!!! This example is loading the webpack loader with 'rules` of webpack 2. All this examples on README are about webpack 2. Take a time for read little more about webpack 2 features.

@treyhuffine treyhuffine Jan 30, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take time to read my code, the Webpack 2 docs and run the changes yourself before making comments like. I'm using Webpack ^2.2.0, and the "valid" syntax you're claiming is not valid on the docs.

@renatobenks-zz renatobenks-zz Jan 29, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is right man!! Take a time for read little more about features webpack 2, because all examples described on README are using webpack 2 and in webpack 2, it's used rules array for loaders instead loaders array. So, with rules you can use use array, like recommend for webpack, for to set the loaders, or you can use loaders array or loader for a single loader.

@treyhuffine treyhuffine Jan 30, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using Webpack ^2.2.0 and "loaders" is not valid.

@renatobenks-zz renatobenks-zz Jan 30, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because needs use rules with use for loader on webpack 2

// activate source maps via loader query
{
loader: 'css-loader',
Expand All @@ -147,7 +147,7 @@ module.exports = {
options: { sourceMap: true }
}
]
)
})
}
]
},
Expand Down