feat: support typescript #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Why do not use JSDoc and generate declarations?
Collaborator
Author
|
That's what I used, but I still need to document the JS files. |
Collaborator
Author
|
Ping @evilebottnawi |
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 8 +1
Lines 154 159 +5
Branches 41 39 -2
=========================================
+ Hits 154 159 +5
Continue to review full report at Codecov.
|
ricardogobbosouza
force-pushed
the
feat-types
branch
2 times, most recently
from
7e9afc7 to
e564167
Compare
ricardogobbosouza
force-pushed
the
feat-types
branch
from
e564167 to
7ee16de
Compare
ricardogobbosouza
force-pushed
the
feat-types
branch
from
0ebc0ce to
efa34e8
Compare
Collaborator
Author
|
@evilebottnawi Do you want to review or can I merge? |
alexander-akait
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Resolve #4
Breaking Changes
No
Additional Info
No