Skip to content

Conversation

@ricardogobbosouza
Copy link
Collaborator

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Resolve #65

Breaking Changes

Additional Info

@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #66 (9fca649) into master (cef4f74) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #66   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          256       245   -11     
  Branches        71        66    -5     
=========================================
- Hits           256       245   -11     
Impacted Files Coverage Δ
src/options.js 100.00% <ø> (ø)
src/getESLint.js 100.00% <100.00%> (ø)
src/index.js 100.00% <100.00%> (ø)
src/linter.js 100.00% <100.00%> (ø)
src/utils.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cef4f74...9fca649. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honestly we trying to avoid using esModuleInterop and allowSyntheticDefaultImports, this creates problems in some configuration

@ricardogobbosouza
Copy link
Collaborator Author

I will remove and correct possible problems

@ricardogobbosouza ricardogobbosouza merged commit 4daddf5 into master Feb 1, 2021
@ricardogobbosouza ricardogobbosouza deleted the fix-ts branch February 1, 2021 13:36
@ArcanoxDragon
Copy link

This PR looks like it reverted most of #42, and as a result, I am experiencing the This expression is not constructible error with allowSyntheticDefaultImports enabled now on 2.5.4. I need allowSyntheticDefaultImports in my build-time tsconfig.json for other reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TS Typing error: "This expression is not constructable." when esModuleInterop is false

4 participants