Skip to content

support alias with a query#33

Closed
chinesedfan wants to merge 2 commits intowebpack:masterfrom
chinesedfan:alias_query
Closed

support alias with a query#33
chinesedfan wants to merge 2 commits intowebpack:masterfrom
chinesedfan:alias_query

Conversation

@chinesedfan
Copy link

Enhanced #22.

Fixes #1289, #1513, #2465 in webpack.

@chinesedfan chinesedfan closed this Aug 3, 2016
@chinesedfan chinesedfan reopened this Aug 3, 2016
@chinesedfan
Copy link
Author

I don't know why this pr does not trigger the CI at first. So I close it and reopen.

@codecov-io
Copy link

codecov-io commented Aug 3, 2016

Current coverage is 92.73% (diff: 100%)

Merging #33 into master will increase coverage by 0.05%

@@             master        #33   diff @@
==========================================
  Files            38         38          
  Lines          1339       1349    +10   
  Methods         222        224     +2   
  Messages          0          0          
  Branches        274        276     +2   
==========================================
+ Hits           1241       1251    +10   
  Misses           98         98          
  Partials          0          0          

Powered by Codecov. Last update ded0f56...4bc8020

@usirin
Copy link

usirin commented Aug 9, 2016

Any update on this?

@sokra
Copy link
Member

sokra commented Aug 17, 2016

I cannot merge this, because it assumes that querystrings are always key-value pairs separated with &, but in fact it's up to the loader implementation to choose the format. They can use any string. And this is done in the wild.

@sokra sokra closed this Aug 17, 2016
@chinesedfan
Copy link
Author

@sokra As loaders can use any string as the query string, is it impossible to implement this feature in fact?

@sokra
Copy link
Member

sokra commented Aug 18, 2016

yep. But you can write a custom resolver plugin (fork of the alias plugin), which implement this only for loaders that use this kind of querystrings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants