Closed
Conversation
Author
|
I don't know why this pr does not trigger the CI at first. So I close it and reopen. |
Current coverage is 92.73% (diff: 100%)@@ master #33 diff @@
==========================================
Files 38 38
Lines 1339 1349 +10
Methods 222 224 +2
Messages 0 0
Branches 274 276 +2
==========================================
+ Hits 1241 1251 +10
Misses 98 98
Partials 0 0
|
|
Any update on this? |
Member
|
I cannot merge this, because it assumes that querystrings are always key-value pairs separated with |
Author
|
@sokra As loaders can use any string as the query string, is it impossible to implement this feature in fact? |
Member
|
yep. But you can write a custom resolver plugin (fork of the alias plugin), which implement this only for loaders that use this kind of querystrings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhanced #22.
Fixes #1289, #1513, #2465 in webpack.