Move filesize to dev dependencies #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's only used in the client
realityking
changed the title
|
Is client bundled before publishing? |
| @@ -37,7 +37,6 @@ | |||
| "acorn-walk": "^8.0.0", | |||
| "chalk": "^4.1.0", | |||
There was a problem hiding this comment.
Can be replaced by colorette (light, fast and with simple API), already used in webpack-cli@4, so for developers which use webpack-cli and webpack-bundle-analyzer we will have less deps
There was a problem hiding this comment.
Good point but something for a different PR :)
valscion
approved these changes
Dec 2, 2020
valscion
added a commit
that referenced
this pull request
Dec 2, 2020
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's only used in the client