Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: webpack v4 needs terser v4 #378

Merged
merged 3 commits into from
Jan 15, 2021
Merged

doc: webpack v4 needs terser v4 #378

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a882a3
doc: webpack v4 needs terser v4
rap2hpoutre Jan 15, 2021
3fef51c
chore: fix
rap2hpoutre Jan 15, 2021
3b57de6
chore: format
rap2hpoutre Jan 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ This plugin uses [terser](https://github.com/terser-js/terser) to minify your Ja

## Getting Started

If you are using webpack v5 or above you do not need to install this plugin. Webpack v5 comes with the latest `terser-webpack-plugin` out of the box.
If you are using webpack v5 or above you do not need to install this plugin. Webpack v5 comes with the latest `terser-webpack-plugin` out of the box. Using Webpack v4, you have to install `terser-webpack-plugin` v4.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please describe it here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your answer. Do you mean I have to (1) additionally describe it here OR (2) remove what I suggested and add it there only?

Suggestion:

If you are using webpack v5 or above you do not need to install this plugin. Webpack v5 comes with the latest terser-webpack-plugin out of the box. Using Webpack v4, you have to install terser-webpack-plugin v4.

Copy link
Member

@alexander-akait alexander-akait Jan 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to change original setup, let's describe separately about webpack@4, anyway I strongly recommend to migrate on v5

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-akait I just removed my original suggestion and tried to follow your advice. Let me know if it's OK!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is OK 👍

To begin, you'll need to install `terser-webpack-plugin`:

Expand Down