Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to install it if you use webpack v4+ #353

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

antonk52
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Some people still install and set up this plugin in their webpack explicitly. The proposed line in the readme is supposed to make it easier for the newcomers.

Breaking Changes

none

Additional Info

@jsf-clabot
Copy link

jsf-clabot commented Oct 29, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #353 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #353   +/-   ##
=======================================
  Coverage   97.01%   97.01%           
=======================================
  Files           3        3           
  Lines         302      302           
  Branches      126      126           
=======================================
  Hits          293      293           
  Misses          8        8           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bececa0...8e71bed. Read the comment docs.

@alexander-akait
Copy link
Member

There is interesting case, if you use webpack@4 you can install this plugin just using another version

@alexander-akait
Copy link
Member

webpack@5 uses the latest version of this plugin

@antonk52
Copy link
Contributor Author

Yep, with webpack v4 it was a common practice to install this plugin explicitly in order to use the latest version. Since currently the latest webpack version is 5 I do not think this needs to be addressed in the readme. Though I am fine with either way. If you can think of a better way to phrase this I am happy to make the idea more transparent for the users.

@alexander-akait
Copy link
Member

If you can think of a better way to phrase this I am happy to make the idea more transparent for the users.

Maybe we add this only for webpack@5? Because currently it can be some misleading for v4

@alexander-akait alexander-akait merged commit 661d1f8 into webpack-contrib:master Oct 29, 2020
@alexander-akait
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants