-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No need to install it if you use webpack v4+ #353
Conversation
Codecov Report
@@ Coverage Diff @@
## master #353 +/- ##
=======================================
Coverage 97.01% 97.01%
=======================================
Files 3 3
Lines 302 302
Branches 126 126
=======================================
Hits 293 293
Misses 8 8
Partials 1 1 Continue to review full report at Codecov.
|
There is interesting case, if you use webpack@4 you can install this plugin just using another version |
webpack@5 uses the latest version of this plugin |
Yep, with webpack v4 it was a common practice to install this plugin explicitly in order to use the latest version. Since currently the latest webpack version is 5 I do not think this needs to be addressed in the readme. Though I am fine with either way. If you can think of a better way to phrase this I am happy to make the idea more transparent for the users. |
Maybe we add this only for webpack@5? Because currently it can be some misleading for v4 |
Thanks |
This PR contains a:
Motivation / Use-Case
Some people still install and set up this plugin in their webpack explicitly. The proposed line in the readme is supposed to make it easier for the newcomers.
Breaking Changes
none
Additional Info