fix: related asset info

webpack-contrib · Sep 19, 2020 · a75dc8b · a75dc8b
1 parent 4103571
commit a75dc8b
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 21 deletions.
diff --git a/src/index.js b/src/index.js
@@ -457,7 +457,8 @@ class TerserPlugin {
           if (extractedCommentsSource) {
             const { commentsFilename } = output;
 
-            newInfo.related = { license: commentsFilename };
+            // TODO `...` required only for webpack@4
+            newInfo.related = { license: commentsFilename, ...info.related };
 
             allExtractedComments.set(name, {
               extractedCommentsSource,

diff --git a/test/TerserPlugin.test.js b/test/TerserPlugin.test.js
@@ -946,8 +946,8 @@ describe('TerserPlugin', () => {
     }
 
     expect(readsAssets(compiler, stats)).toMatchSnapshot('assets');
-    expect(getWarnings(stats)).toMatchSnapshot('errors');
-    expect(getErrors(stats)).toMatchSnapshot('warnings');
+    expect(getWarnings(stats)).toMatchSnapshot('warnings');
+    expect(getErrors(stats)).toMatchSnapshot('errors');
 
     await new Promise(async (resolve) => {
       const newStats = await compile(compiler);
@@ -1007,8 +1007,8 @@ describe('TerserPlugin', () => {
     }
 
     expect(readsAssets(compiler, stats)).toMatchSnapshot('assets');
-    expect(getWarnings(stats)).toMatchSnapshot('errors');
-    expect(getErrors(stats)).toMatchSnapshot('warnings');
+    expect(getWarnings(stats)).toMatchSnapshot('warnings');
+    expect(getErrors(stats)).toMatchSnapshot('errors');
 
     await new Promise(async (resolve) => {
       const newStats = await compile(compiler);
@@ -1068,8 +1068,8 @@ describe('TerserPlugin', () => {
     }
 
     expect(readsAssets(compiler, stats)).toMatchSnapshot('assets');
-    expect(getWarnings(stats)).toMatchSnapshot('errors');
-    expect(getErrors(stats)).toMatchSnapshot('warnings');
+    expect(getWarnings(stats)).toMatchSnapshot('warnings');
+    expect(getErrors(stats)).toMatchSnapshot('errors');
 
     new ModifyExistingAsset({ name: 'js.js' }).apply(compiler);
 
@@ -1132,8 +1132,8 @@ describe('TerserPlugin', () => {
     }
 
     expect(readsAssets(compiler, stats)).toMatchSnapshot('assets');
-    expect(getWarnings(stats)).toMatchSnapshot('errors');
-    expect(getErrors(stats)).toMatchSnapshot('warnings');
+    expect(getWarnings(stats)).toMatchSnapshot('warnings');
+    expect(getErrors(stats)).toMatchSnapshot('errors');
 
     await new Promise(async (resolve) => {
       const newStats = await compile(compiler);
@@ -1194,8 +1194,8 @@ describe('TerserPlugin', () => {
     }
 
     expect(readsAssets(compiler, stats)).toMatchSnapshot('assets');
-    expect(getWarnings(stats)).toMatchSnapshot('errors');
-    expect(getErrors(stats)).toMatchSnapshot('warnings');
+    expect(getWarnings(stats)).toMatchSnapshot('warnings');
+    expect(getErrors(stats)).toMatchSnapshot('errors');
 
     new ModifyExistingAsset({ name: 'js.js' }).apply(compiler);
 
@@ -1251,8 +1251,8 @@ describe('TerserPlugin', () => {
     }
 
     expect(readsAssets(compiler, stats)).toMatchSnapshot('assets');
-    expect(getWarnings(stats)).toMatchSnapshot('errors');
-    expect(getErrors(stats)).toMatchSnapshot('warnings');
+    expect(getWarnings(stats)).toMatchSnapshot('warnings');
+    expect(getErrors(stats)).toMatchSnapshot('errors');
 
     await new Promise(async (resolve) => {
       const newStats = await compile(compiler);
@@ -1306,8 +1306,8 @@ describe('TerserPlugin', () => {
     }
 
     expect(readsAssets(compiler, stats)).toMatchSnapshot('assets');
-    expect(getWarnings(stats)).toMatchSnapshot('errors');
-    expect(getErrors(stats)).toMatchSnapshot('warnings');
+    expect(getWarnings(stats)).toMatchSnapshot('warnings');
+    expect(getErrors(stats)).toMatchSnapshot('errors');
 
     new ModifyExistingAsset({ name: 'two.js', comment: true }).apply(compiler);
 
@@ -1367,8 +1367,8 @@ describe('TerserPlugin', () => {
     }
 
     expect(readsAssets(compiler, stats)).toMatchSnapshot('assets');
-    expect(getWarnings(stats)).toMatchSnapshot('errors');
-    expect(getErrors(stats)).toMatchSnapshot('warnings');
+    expect(getWarnings(stats)).toMatchSnapshot('warnings');
+    expect(getErrors(stats)).toMatchSnapshot('errors');
 
     await new Promise(async (resolve) => {
       const newStats = await compile(compiler);
@@ -1426,8 +1426,8 @@ describe('TerserPlugin', () => {
     }
 
     expect(readsAssets(compiler, stats)).toMatchSnapshot('assets');
-    expect(getWarnings(stats)).toMatchSnapshot('errors');
-    expect(getErrors(stats)).toMatchSnapshot('warnings');
+    expect(getWarnings(stats)).toMatchSnapshot('warnings');
+    expect(getErrors(stats)).toMatchSnapshot('errors');
 
     new ModifyExistingAsset({ name: 'two.js', comment: true }).apply(compiler);
 
@@ -1489,8 +1489,8 @@ describe('TerserPlugin', () => {
     }
 
     expect(readsAssets(compiler, stats)).toMatchSnapshot('assets');
-    expect(getWarnings(stats)).toMatchSnapshot('errors');
-    expect(getErrors(stats)).toMatchSnapshot('warnings');
+    expect(getWarnings(stats)).toMatchSnapshot('warnings');
+    expect(getErrors(stats)).toMatchSnapshot('errors');
 
     await new Promise(async (resolve) => {
       const newStats = await compile(compiler);