This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Update readme to fit webpack v2 #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
TheLarkInn
suggested changes
Jan 11, 2017
README.md
Outdated
| { | ||
| test: /\.js$/, | ||
| loader: "source-map-loader" | ||
| loader: "source-map-loader", |
Contributor
There was a problem hiding this comment.
can this be use: ["source-map-loader"]
Contributor
There was a problem hiding this comment.
I believe it can also simply be a string as well last time I checked.
Contributor
Author
There was a problem hiding this comment.
For sure. I used this as the example so you might want to update that as well.
Contributor
Author
|
@TheLarkInn checkout that change if you will. Also sorry for the vim keys at the end of the commit message. |
TheLarkInn
approved these changes
Jan 11, 2017
Contributor
|
Looks good for now. Still has more work to do for webpack/webpack#3195 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Updates README.md to adhere to webpack v2 loader updates. webpack/webpack issue #3195