docs(README): add autoprefixing example #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-preset-env, because it already includes autoprefixer
halfzebra
requested review from
alexander-akait and
michael-ciniawsky
as code owners
michael-ciniawsky
requested changes
Aug 4, 2018
README.md
Outdated
| } | ||
| ``` | ||
|
|
||
| > :warning: [`postcss-preset-env`](https://github.com/csstools/postcss-preset-env/issues) includes autoprefixer, so adding it is not necessary if you use the preset. |
There was a problem hiding this comment.
- Drop the
/issuesfragment from the link please - Maybe also link to the autoprefixer repo similiar to how it's done for
postcss-preset-env
Optional
- , so adding it ...
+ , so adding it **separately** ... you **already** use the ...| @@ -192,9 +192,8 @@ module.exports = ({ file, options, env }) => ({ | |||
| options: { | |||
| config: { | |||
| ctx: { | |||
| cssnext: {...options}, | |||
| 'postcss-preset-env': {...options}, | |||
There was a problem hiding this comment.
Using 'postcss-preset-env' as the key here conflicts with the usage in the config file (options.presetEnv) above, one would have to access it via bracket notation options['postcss-preset-env'] instead of dot notation (options.presetEnv) as currently used. Either rename the key in webpack.config.js or use bracket notation in postcss.confg.js aswell :)
There was a problem hiding this comment.
Good catch, thanks for the feedback! I have addressed it by renaming the options.presetEnv -> options['postcss-preset-env']
michael-ciniawsky
changed the title
michael-ciniawsky
added
status: approved
and removed
ci: failed
pr: refactor
priority: medium
status: pending
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up PR to #379
TypeSemVerIssuesChecklist