-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CSS ordering for config with multiple entry points #130
Fix CSS ordering for config with multiple entry points #130
Conversation
|
/cc @sokra |
@bawjensen thanks for solid PR |
@bawjensen can you rebase you PR, thanks! |
e48f1f9
to
a2900c4
Compare
whoops, the history might've gotten a little messed up because I did a |
@evilebottnawi Can this get merged? I could definitely use this fix |
@evilebottnawi any update? Or any update from @sokra given you've been assigned? |
In near future @sokra will answer, sorry for delay |
This should probably be fixed in webpack instead. I'll check how to do this. |
@sokra you mean that the My understanding is that |
I guess this could be best solved with a (new) per chunk group index in webpack. |
Awesome, thanks for working on that! I'm guessing most of this PR will end up being useless? Except perhaps the unit test |
@sokra once that PR's posted, will it be mentioned here so that we can follow the progress? |
@sokra any update? I'm curious if I should import my fork into the project, to have an immediate fix, if the proper fix isn't coming quite yet. |
@sokra can we merge and release new version? |
thanks @sokra and @evilebottnawi! |
1. duplicated generated override style 2. unexpected style order, override style should be at the end of the extracted style bundle. (ref: webpack-contrib/mini-css-extract-plugin#130)
1. duplicated generated override style 2. unexpected style order, override style should be at the end of the extracted style bundle. (ref: webpack-contrib/mini-css-extract-plugin#130)
1. duplicated generated override style 2. unexpected style order, override style should be at the end of the extracted style bundle. (ref: webpack-contrib/mini-css-extract-plugin#130)
1. duplicated generated override style 2. unexpected style order, override style should be at the end of the extracted style bundle. (ref: webpack-contrib/mini-css-extract-plugin#130)
Hey, this is a rough draft of a fix for #115. The code I wrote is pretty verbose as I didn't want to pull in any dependencies such as lodash or flatten. Let me know what I can do to improve it and get it ready for merging
fixes #115