Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS ordering for config with multiple entry points #130

Merged
merged 8 commits into from
Jun 29, 2018

Conversation

bawjensen
Copy link
Contributor

@bawjensen bawjensen commented May 5, 2018

Hey, this is a rough draft of a fix for #115. The code I wrote is pretty verbose as I didn't want to pull in any dependencies such as lodash or flatten. Let me know what I can do to improve it and get it ready for merging

fixes #115

@jsf-clabot
Copy link

jsf-clabot commented May 5, 2018

CLA assistant check
All committers have signed the CLA.

@bawjensen
Copy link
Contributor Author

bawjensen commented May 5, 2018

I signed the CLA, I guess it has yet to propagate though There we go

@alexander-akait alexander-akait requested a review from sokra May 6, 2018 12:14
@alexander-akait
Copy link
Member

/cc @sokra

@alexander-akait
Copy link
Member

@bawjensen thanks for solid PR

@alexander-akait
Copy link
Member

@bawjensen can you rebase you PR, thanks!

@bawjensen bawjensen force-pushed the fix-multiple-entry branch from e48f1f9 to a2900c4 Compare May 7, 2018 17:47
@bawjensen
Copy link
Contributor Author

whoops, the history might've gotten a little messed up because I did a git push --force. Anyway, it's rebased now and the merge conflict is gone

@verydanny
Copy link
Contributor

@evilebottnawi Can this get merged? I could definitely use this fix

@bawjensen
Copy link
Contributor Author

@evilebottnawi any update? Or any update from @sokra given you've been assigned?

@alexander-akait
Copy link
Member

In near future @sokra will answer, sorry for delay

@sokra
Copy link
Member

sokra commented May 11, 2018

This should probably be fixed in webpack instead. I'll check how to do this.

@bawjensen
Copy link
Contributor Author

@sokra you mean that the index2 (which I understand comes from webpack) should already be the correct value?

My understanding is that index2 is a value global to the build, but with multiple entry points you'd want the ordering to be localized to the entry point (and each entry point might have a different ordering).

@sokra
Copy link
Member

sokra commented May 12, 2018

I guess this could be best solved with a (new) per chunk group index in webpack. index and index2 stay. Already working on a PR to add this to the core.

@bawjensen
Copy link
Contributor Author

bawjensen commented May 12, 2018

Awesome, thanks for working on that! I'm guessing most of this PR will end up being useless? Except perhaps the unit test

@bawjensen
Copy link
Contributor Author

@sokra once that PR's posted, will it be mentioned here so that we can follow the progress?

@bawjensen
Copy link
Contributor Author

@sokra any update? I'm curious if I should import my fork into the project, to have an immediate fix, if the proper fix isn't coming quite yet.

@sokra sokra mentioned this pull request Jun 29, 2018
6 tasks
@alexander-akait
Copy link
Member

@sokra can we merge and release new version?

@alexander-akait alexander-akait merged commit 79373eb into webpack-contrib:master Jun 29, 2018
@bawjensen bawjensen deleted the fix-multiple-entry branch June 29, 2018 19:01
@bawjensen
Copy link
Contributor Author

thanks @sokra and @evilebottnawi!

ulivz added a commit to vuejs/vuepress that referenced this pull request Jul 8, 2018
1. duplicated generated override style
2. unexpected style order, override style should be at the end of the extracted style bundle. (ref: webpack-contrib/mini-css-extract-plugin#130)
ulivz added a commit to vuejs/vuepress that referenced this pull request Jul 8, 2018
1. duplicated generated override style
2. unexpected style order, override style should be at the end of the extracted style bundle. (ref: webpack-contrib/mini-css-extract-plugin#130)
shaun554 added a commit to shaun554/vuepress that referenced this pull request Mar 21, 2019
1. duplicated generated override style
2. unexpected style order, override style should be at the end of the extracted style bundle. (ref: webpack-contrib/mini-css-extract-plugin#130)
devs-cloud pushed a commit to devs-cloud/vue-dev that referenced this pull request Dec 27, 2019
1. duplicated generated override style
2. unexpected style order, override style should be at the end of the extracted style bundle. (ref: webpack-contrib/mini-css-extract-plugin#130)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-entry point config: Ordering not matching JS import order
5 participants