fix: avoid to throw error when link doesn't have parentNode (#1016)

webpack-contrib · Mar 7, 2023 · 6292440 · 6292440
1 parent cab796f
commit 6292440
Show file tree

Hide file tree

Showing 11 changed files with 9 additions and 9 deletions.
diff --git a/src/index.js b/src/index.js
@@ -862,7 +862,7 @@ class MiniCssExtractPlugin {
                     'err.code = "CSS_CHUNK_LOAD_FAILED";',
                     "err.type = errorType;",
                     "err.request = realHref;",
-                    "linkTag.parentNode.removeChild(linkTag)",
+                    "if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag)",
                     "reject(err);",
                   ]),
                   "}",

diff --git a/...5-importModule/0.4568ffdcdfced785eabc.css → ...5-importModule/0.b1a0d51fa05593feebfa.css b/...5-importModule/0.4568ffdcdfced785eabc.css → ...5-importModule/0.b1a0d51fa05593feebfa.css
diff --git a/...k-5-importModule/4568ffdcdfced785eabc.css → ...k-5-importModule/b1a0d51fa05593feebfa.css b/...k-5-importModule/4568ffdcdfced785eabc.css → ...k-5-importModule/b1a0d51fa05593feebfa.css
diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/main.js b/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/main.js
@@ -73,7 +73,7 @@ __webpack_require__.r(__webpack_exports__);
 /******/ 	
 /******/ 	/* webpack/runtime/getFullHash */
 /******/ 	(() => {
-/******/ 		__webpack_require__.h = () => ("4568ffdcdfced785eabc")
+/******/ 		__webpack_require__.h = () => ("b1a0d51fa05593feebfa")
 /******/ 	})();
 /******/ 	
 /******/ 	/* webpack/runtime/global */
@@ -189,7 +189,7 @@ __webpack_require__.r(__webpack_exports__);
 /******/ 					err.code = "CSS_CHUNK_LOAD_FAILED";
 /******/ 					err.type = errorType;
 /******/ 					err.request = realHref;
-/******/ 					linkTag.parentNode.removeChild(linkTag)
+/******/ 					if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag)
 /******/ 					reject(err);
 /******/ 				}
 /******/ 			}

diff --git a/...cted/webpack-5/0.9ee2d65d5d13f2b4323d.css → ...cted/webpack-5/0.775d09b0a3e56e73fd45.css b/...cted/webpack-5/0.9ee2d65d5d13f2b4323d.css → ...cted/webpack-5/0.775d09b0a3e56e73fd45.css
diff --git a/...pected/webpack-5/9ee2d65d5d13f2b4323d.css → ...pected/webpack-5/775d09b0a3e56e73fd45.css b/...pected/webpack-5/9ee2d65d5d13f2b4323d.css → ...pected/webpack-5/775d09b0a3e56e73fd45.css
diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5/main.js b/test/cases/chunkFilename-fullhash/expected/webpack-5/main.js
@@ -73,7 +73,7 @@ __webpack_require__.r(__webpack_exports__);
 /******/ 	
 /******/ 	/* webpack/runtime/getFullHash */
 /******/ 	(() => {
-/******/ 		__webpack_require__.h = () => ("9ee2d65d5d13f2b4323d")
+/******/ 		__webpack_require__.h = () => ("775d09b0a3e56e73fd45")
 /******/ 	})();
 /******/ 	
 /******/ 	/* webpack/runtime/global */
@@ -189,7 +189,7 @@ __webpack_require__.r(__webpack_exports__);
 /******/ 					err.code = "CSS_CHUNK_LOAD_FAILED";
 /******/ 					err.type = errorType;
 /******/ 					err.request = realHref;
-/******/ 					linkTag.parentNode.removeChild(linkTag)
+/******/ 					if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag)
 /******/ 					reject(err);
 /******/ 				}
 /******/ 			}

diff --git a/test/cases/hmr/expected/main.js b/test/cases/hmr/expected/main.js
@@ -952,7 +952,7 @@ __webpack_require__.r(__webpack_exports__);
 /******/ 					err.code = "CSS_CHUNK_LOAD_FAILED";
 /******/ 					err.type = errorType;
 /******/ 					err.request = realHref;
-/******/ 					linkTag.parentNode.removeChild(linkTag)
+/******/ 					if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag)
 /******/ 					reject(err);
 /******/ 				}
 /******/ 			}

diff --git a/test/cases/insert-function/expected/main.js b/test/cases/insert-function/expected/main.js
@@ -173,7 +173,7 @@
 /******/ 					err.code = "CSS_CHUNK_LOAD_FAILED";
 /******/ 					err.type = errorType;
 /******/ 					err.request = realHref;
-/******/ 					linkTag.parentNode.removeChild(linkTag)
+/******/ 					if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag)
 /******/ 					reject(err);
 /******/ 				}
 /******/ 			}

diff --git a/test/cases/insert-string/expected/main.js b/test/cases/insert-string/expected/main.js
@@ -173,7 +173,7 @@
 /******/ 					err.code = "CSS_CHUNK_LOAD_FAILED";
 /******/ 					err.type = errorType;
 /******/ 					err.request = realHref;
-/******/ 					linkTag.parentNode.removeChild(linkTag)
+/******/ 					if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag)
 /******/ 					reject(err);
 /******/ 				}
 /******/ 			}

diff --git a/test/cases/insert-undefined/expected/main.js b/test/cases/insert-undefined/expected/main.js
@@ -173,7 +173,7 @@
 /******/ 					err.code = "CSS_CHUNK_LOAD_FAILED";
 /******/ 					err.type = errorType;
 /******/ 					err.request = realHref;
-/******/ 					linkTag.parentNode.removeChild(linkTag)
+/******/ 					if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag)
 /******/ 					reject(err);
 /******/ 				}
 /******/ 			}