fix: don't crash in web workers (#1004)

webpack-contrib · Dec 6, 2022 · 4d98d4b · 4d98d4b
1 parent 5ef989b
commit 4d98d4b
Show file tree

Hide file tree

Showing 16 changed files with 44 additions and 7 deletions.
diff --git a/src/index.js b/src/index.js
@@ -825,6 +825,7 @@ class MiniCssExtractPlugin {
           }
 
           return Template.asString([
+            'if (typeof document === "undefined") return;',
             `var createStylesheet = ${runtimeTemplate.basicFunction(
               "chunkId, fullhref, oldTag, resolve, reject",
               [

diff --git a/...5-importModule/0.945622d4f51f3fe3a0d0.css → ...5-importModule/0.4568ffdcdfced785eabc.css b/...5-importModule/0.945622d4f51f3fe3a0d0.css → ...5-importModule/0.4568ffdcdfced785eabc.css
diff --git a/...k-5-importModule/945622d4f51f3fe3a0d0.css → ...k-5-importModule/4568ffdcdfced785eabc.css b/...k-5-importModule/945622d4f51f3fe3a0d0.css → ...k-5-importModule/4568ffdcdfced785eabc.css
diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/main.js b/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/main.js
@@ -73,7 +73,7 @@ __webpack_require__.r(__webpack_exports__);
 /******/ 	
 /******/ 	/* webpack/runtime/getFullHash */
 /******/ 	(() => {
-/******/ 		__webpack_require__.h = () => ("945622d4f51f3fe3a0d0")
+/******/ 		__webpack_require__.h = () => ("4568ffdcdfced785eabc")
 /******/ 	})();
 /******/ 	
 /******/ 	/* webpack/runtime/global */
@@ -171,6 +171,7 @@ __webpack_require__.r(__webpack_exports__);
 /******/ 	
 /******/ 	/* webpack/runtime/css loading */
 /******/ 	(() => {
+/******/ 		if (typeof document === "undefined") return;
 /******/ 		var createStylesheet = (chunkId, fullhref, oldTag, resolve, reject) => {
 /******/ 			var linkTag = document.createElement("link");
 /******/ 		

diff --git a/...cted/webpack-5/0.de494c1e7411c41d8362.css → ...cted/webpack-5/0.9ee2d65d5d13f2b4323d.css b/...cted/webpack-5/0.de494c1e7411c41d8362.css → ...cted/webpack-5/0.9ee2d65d5d13f2b4323d.css
diff --git a/...pected/webpack-5/de494c1e7411c41d8362.css → ...pected/webpack-5/9ee2d65d5d13f2b4323d.css b/...pected/webpack-5/de494c1e7411c41d8362.css → ...pected/webpack-5/9ee2d65d5d13f2b4323d.css
diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5/main.js b/test/cases/chunkFilename-fullhash/expected/webpack-5/main.js
@@ -73,7 +73,7 @@ __webpack_require__.r(__webpack_exports__);
 /******/ 	
 /******/ 	/* webpack/runtime/getFullHash */
 /******/ 	(() => {
-/******/ 		__webpack_require__.h = () => ("de494c1e7411c41d8362")
+/******/ 		__webpack_require__.h = () => ("9ee2d65d5d13f2b4323d")
 /******/ 	})();
 /******/ 	
 /******/ 	/* webpack/runtime/global */
@@ -171,6 +171,7 @@ __webpack_require__.r(__webpack_exports__);
 /******/ 	
 /******/ 	/* webpack/runtime/css loading */
 /******/ 	(() => {
+/******/ 		if (typeof document === "undefined") return;
 /******/ 		var createStylesheet = (chunkId, fullhref, oldTag, resolve, reject) => {
 /******/ 			var linkTag = document.createElement("link");
 /******/ 		

diff --git a/test/cases/hmr/expected/main.js b/test/cases/hmr/expected/main.js
@@ -934,6 +934,7 @@ __webpack_require__.r(__webpack_exports__);
 /******/ 	
 /******/ 	/* webpack/runtime/css loading */
 /******/ 	(() => {
+/******/ 		if (typeof document === "undefined") return;
 /******/ 		var createStylesheet = (chunkId, fullhref, oldTag, resolve, reject) => {
 /******/ 			var linkTag = document.createElement("link");
 /******/ 		

diff --git a/test/cases/insert-function/expected/main.js b/test/cases/insert-function/expected/main.js
@@ -155,6 +155,7 @@
 /******/ 	
 /******/ 	/* webpack/runtime/css loading */
 /******/ 	(() => {
+/******/ 		if (typeof document === "undefined") return;
 /******/ 		var createStylesheet = (chunkId, fullhref, oldTag, resolve, reject) => {
 /******/ 			var linkTag = document.createElement("link");
 /******/ 		

diff --git a/test/cases/insert-string/expected/main.js b/test/cases/insert-string/expected/main.js
@@ -155,6 +155,7 @@
 /******/ 	
 /******/ 	/* webpack/runtime/css loading */
 /******/ 	(() => {
+/******/ 		if (typeof document === "undefined") return;
 /******/ 		var createStylesheet = (chunkId, fullhref, oldTag, resolve, reject) => {
 /******/ 			var linkTag = document.createElement("link");
 /******/ 		

diff --git a/test/cases/insert-undefined/expected/main.js b/test/cases/insert-undefined/expected/main.js
@@ -155,6 +155,7 @@
 /******/ 	
 /******/ 	/* webpack/runtime/css loading */
 /******/ 	(() => {
+/******/ 		if (typeof document === "undefined") return;
 /******/ 		var createStylesheet = (chunkId, fullhref, oldTag, resolve, reject) => {
 /******/ 			var linkTag = document.createElement("link");
 /******/ 		

diff --git a/test/manual/index.html b/test/manual/index.html
@@ -5,7 +5,7 @@
     <meta http-equiv="X-UA-Compatible" content="IE=edge" />
     <title>mini-css-extract-plugin testcase</title>
     <meta name="viewport" content="width=device-width, initial-scale=1" />
-    <link rel="stylesheet" type="text/css" href="/dist/preloaded1.chunk.css" />
+    <link rel="stylesheet" type="text/css" href="dist/preloaded1.chunk.css" />
     <style>
       .test {
         background: lightcoral;
@@ -23,7 +23,7 @@
         background: lightgreen;
       }
     </style>
-    <link rel="stylesheet" type="text/css" href="/dist/main.css" />
+    <link rel="stylesheet" type="text/css" href="dist/main.css" />
   </head>
   <body>
     <div class="test initial-css">Initial CSS: Must be green</div>
@@ -97,6 +97,6 @@
       </p>
     </div>
     <div class="errors"></div>
-    <script async defer src="/dist/main.js"></script>
+    <script async defer src="dist/main.js"></script>
   </body>
 </html>
diff --git a/test/manual/src/index.js b/test/manual/src/index.js
@@ -94,3 +94,11 @@ makeButton(".crossorigin", () => {
   __webpack_public_path__ = originalPublicPath;
   return promise;
 });
+
+const worker = new Worker(new URL("./worker.js", import.meta.url));
+
+worker.postMessage("test");
+
+worker.addEventListener("message", (event) => {
+  console.log(`Received message from worker: ${event.data}`);
+});
diff --git a/test/manual/src/worker.css b/test/manual/src/worker.css
@@ -0,0 +1,3 @@
+body {
+  background: green;
+}
diff --git a/test/manual/src/worker.js b/test/manual/src/worker.js
@@ -0,0 +1,15 @@
+import "./worker.css";
+
+// eslint-disable-next-line no-undef
+self.onmessage = (event) => {
+  console.log(`Received message from application: ${event.data}`);
+
+  // eslint-disable-next-line no-undef
+  self.postMessage("I'm alive!");
+};
+
+async function load() {
+  return import("./simple.css");
+}
+
+load();
diff --git a/test/manual/webpack.config.js b/test/manual/webpack.config.js
@@ -12,11 +12,15 @@ const ENABLE_ES_MODULE =
     : true;
 
 const OLD_API =
-  typeof process.env.OLD_API !== "undefined" ? yn(process.env.OLD_API) : true;
+  typeof process.env.OLD_API !== "undefined" ? yn(process.env.OLD_API) : false;
 
-console.log(OLD_API);
+console.log("OPTIONS:");
+console.log("ENABLE_HMR:", ENABLE_HMR);
+console.log("ENABLE_ES_MODULE:", ENABLE_ES_MODULE);
+console.log("OLD_API:", OLD_API);
 
 module.exports = {
+  devtool: false,
   mode: "development",
   output: {
     chunkFilename: "[name].chunk.js",