fix: fix #111 by generating sourcemaps even when a previous loader didn't pass them #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dn't pass them
| };" | ||
| `; | ||
|
|
||
| exports[`loader should work with source maps when the "devtool" option is enabled: warnings 1`] = `Array []`; |
There was a problem hiding this comment.
I didn't remove the test, I rewrote it.
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
==========================================
+ Coverage 91.81% 92.03% +0.21%
==========================================
Files 3 3
Lines 220 226 +6
Branches 85 86 +1
==========================================
+ Hits 202 208 +6
Misses 12 12
Partials 6 6
Continue to review full report at Codecov.
|
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
See isse #111.
imports-loaderwas only generating sourcemaps when a previous loader in the chain had already provided one. Webpack itself still generates a sourcemap in these conditions, but it was incorrect due to the missing mappings for the code injected byimports-loader.There is probably some room for improvement here, would be good to map an artificial source file for the code which was injected by
imports-loader.The existing tests were not very good - they checked that the compilation had run and produced an output JS file, but didn't even check that sourcemaps had been generated, let alone that the sourcemap was correct.