feat: percent resize unit #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will fix lint problems (need update some deps before release) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #448 +/- ##
==========================================
+ Coverage 77.16% 77.74% +0.58%
==========================================
Files 4 4
Lines 727 746 +19
Branches 282 296 +14
==========================================
+ Hits 561 580 +19
Misses 137 137
Partials 29 29 ☔ View full report in Codecov by Sentry. |
alexander-akait
merged commit a83f491
into
webpack-contrib:master
13 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
For years I've had to use a custom image loader to allow me to generate non-retina resized images on the fly via webpack from retina-sized images in the source code. But since recently upgrading to webpack 5 and getting familiarized with its new capabilities and patterns (including your plugin here), your plugin's generator functionality seems to be the best place for that sort of functionality instead. So hopefully you agree that this PR adds the ability to do percentage-based resizing of generated images as minimally and idiomatically as I've tried to. But let me know if you have any concerns I might address in order to get this approved and merged. 🙇 🤝
Breaking Changes
no breaking changes
Additional Info