Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed cjs wrapper #282

Merged
merged 3 commits into from
Dec 16, 2021
Merged

feat: removed cjs wrapper #282

merged 3 commits into from
Dec 16, 2021

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

removed cjs wrapper and generated types in commonjs format (export = and namespaces used in types), now you can directly use exported types

Breaking Changes

Potentially yes, but we use babel and our code in commonjs format, but types in ESM, so it is fix

Additional Info

No

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #282 (edc7159) into master (57d7c11) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
+ Coverage   86.71%   86.88%   +0.17%     
==========================================
  Files           5        4       -1     
  Lines         557      572      +15     
  Branches      229      229              
==========================================
+ Hits          483      497      +14     
- Misses         66       67       +1     
  Partials        8        8              
Impacted Files Coverage Δ
src/index.js 97.85% <100.00%> (+0.12%) ⬆️
src/loader.js 97.29% <100.00%> (+0.19%) ⬆️
src/utils.js 77.95% <100.00%> (-0.18%) ⬇️
src/worker.js 97.77% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57d7c11...edc7159. Read the comment docs.

@alexander-akait alexander-akait merged commit f0fa0a7 into master Dec 16, 2021
@alexander-akait alexander-akait deleted the feat-remove-cjs-wrapper branch December 16, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant