Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

fix(schema): added description on esModule #358

Merged
merged 2 commits into from
Dec 30, 2019

Conversation

smondal
Copy link
Contributor

@smondal smondal commented Dec 29, 2019

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Added 'description' field on esModule option.

Breaking Changes

Additional Info

@codecov
Copy link

codecov bot commented Dec 29, 2019

Codecov Report

Merging #358 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #358   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          29     29           
  Branches       13     13           
=====================================
  Hits           29     29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 190829e...bdcc734. Read the comment docs.

@anikethsaha
Copy link

CI is not passing
run npm run test locally

I guess is there some security alert, you need to do auditing of the dep

@smondal
Copy link
Contributor Author

smondal commented Dec 29, 2019

Yes, Its passing everything in locally.
Screen Shot 2019-12-29 at 4 19 05 PM

@anikethsaha
Copy link

npm audit ?

@smondal
Copy link
Contributor Author

smondal commented Dec 29, 2019

There was a security issue on serialize-javascript, fixed this. thanks @anikethsaha

@anikethsaha
Copy link

cool 👍

@alexander-akait alexander-akait merged commit 5ffac2e into webpack-contrib:master Dec 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants