feat: support ESLint 8.x #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
commented
Sep 6, 2021
12 tasks
MichaelDeBoey
force-pushed
the
eslint-8
branch
from
6f03f64 to
f927c45
Compare
MichaelDeBoey
force-pushed
the
eslint-8
branch
from
f927c45 to
e94417b
Compare
MichaelDeBoey
force-pushed
the
eslint-8
branch
3 times, most recently
from
3b0cdc0 to
3602209
Compare
BREAKING CHANGE: Requires Node@>=12.13 BREAKING CHANGE: Requires ESLint@^7.0.0 || ^8.0.0 BREAKING CHANGE: Requires eslint-plugin-import@^2.25.0
MichaelDeBoey
force-pushed
the
eslint-8
branch
from
3602209 to
7ce89c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESLint v8.0.0 is released 🎉
In theory this config is already compatible with ESLint 8.x.
eslint-webpack-plugin's CI is complaining about this package due toeslint-plugin-importnot being ESLint 8.x compatible (yet) though.Adding it as a
peerDependency, makes it more clear that this package needs it.Wanted to wait until they support ESLint 8.x as adding this package to the
peerDependenciesis technically already a breaking change.devDependency compatibility with ESLint 8:
eslint-find-rules(Support ESLint 8.x sarbbottam/eslint-find-rules#336)v4.0.0eslint-plugin-import(Support ESLint 8.x import-js/eslint-plugin-import#2211)v2.25.0BREAKING CHANGE: Requires Node@>=12.13
BREAKING CHANGE: Requires ESLint@^7.0.0 || ^8.0.0
BREAKING CHANGE: Requires eslint-plugin-import@^2.25.0
Closes #16