test: escaped in selector #973
Conversation
alexander-akait
force-pushed
the
issue-966
branch
2 times, most recently
from
90c8446 to
16256a3
Compare
alexander-akait
force-pushed
the
issue-966
branch
from
16256a3 to
1afde1d
Compare
Codecov Report
@@ Coverage Diff @@
## master #973 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 10 10
Lines 424 424
Branches 126 126
=======================================
Hits 417 417
Misses 7 7Continue to review full report at Codecov.
|
|
/cc @jquense i am merging PR, maybe problem in postcss plugin or something other in configuration? Anyway feel free to feedback in issue |
| Array [ | ||
| Array [ | ||
| 1, | ||
| ".button.hey { |
There was a problem hiding this comment.
the bug is right here: .button.hey is very different than: .button\.hey. The former is a selector for when both .button and .hey are on an element
|
The test case here is not accurate. It illustrates the bug but doesn't contain an assert checking for it |
|
@jquense what you expected? |
|
Let's move discussion in #966 |
| exports.push([module.id, \\".button.hey {\\\\n color: red;\\\\n}\\\\n\\", \\"\\"]); | ||
| // Exports | ||
| exports.locals = { | ||
| \\"button\\": \\"button.hey\\" |
There was a problem hiding this comment.
This is also wrong, but if you escaped in getLocalIdent it would be fixed
This PR contains a:
Motivation / Use-Case
fixes #966
Breaking Changes
No
Additional Info
/cc @jquense looks all fine, can't see problems or bugs