test: add test with escaped characters #493
Conversation
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
======================================
Coverage 98.3% 98.3%
======================================
Files 10 10
Lines 354 354
Branches 79 79
======================================
Hits 348 348
Misses 6 6Continue to review full report at Codecov.
|
| test("escape characters (uppercase)", ".class { content: \"\\F10C\" }", [ | ||
| [1, ".class { content: \"\\F10C\" }", ""] | ||
| ]); | ||
| // Need uncomment after resolve https://github.com/css-modules/postcss-modules-local-by-default/issues/108 |
There was a problem hiding this comment.
Not sure about these tbh, maybe better keep a note and add them when it is resolved :)
There was a problem hiding this comment.
@michael-ciniawsky i think best note is not in code, some issue can resolve in a long time 😭 Be good merge this as is and if some submit about problem related to this add link to issue in other repo maybe it is help solve the problem faster
michael-ciniawsky
changed the title
|
I will update the test suite today, so we can test within a 'real world' scenario ( |
|
@michael-ciniawsky If I'm not mistaken in |
|
Instead of |
|
@michael-ciniawsky yep, I generally see for the first time the project using this module, we tried it in other projects, it did not meet expectations 😭 let's wait |
|
👍 I will open an issue for general overview with all available options here soon, so we can then triage this, but very good catch I'm surprised to be honest 😛 |
* master: fix: case insensitivity of @import (webpack-contrib#514) chore: update comment (webpack-contrib#515) docs(README): improve importLoaders section and example (webpack-contrib#512) docs(README): fix link (webpack-contrib#508) docs(README): fix typo in example (webpack-contrib#507) docs(README): fix typo in maintainers link (webpack-contrib#505) fix: imported variables are replaced in exports if followed by a comma (webpack-contrib#504) docs(README): standardize (webpack-contrib#503) test: `charset` directive (webpack-contrib#502) fix: url with a trailing space is now handled correctly (webpack-contrib#494) fix: use `btoa` instead `Buffer` (webpack-contrib#501) test: add test for escaped characters (webpack-contrib#493) test: add tests for encoded svg data uri (webpack-contrib#492) test: add tests when css contain data uri and source maps are enabled (webpack-contrib#491) fix: loader now correctly handles `url` with space(s) (webpack-contrib#495)
What kind of change does this PR introduce?
Tests
Did you add tests for your changes?
it is tests
If relevant, did you update the README?
not required
Summary
Ref: #459
Does this PR introduce a breaking change?
no
Other information
not required