Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

userScript: add preview mute functionality #25

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Informatic
Copy link
Member

@Informatic Informatic commented Jan 15, 2022

Closes #18

@fire332
Copy link

fire332 commented Jan 16, 2022

For the instantaneous animated previews, the b in the screenshot in #18 must be true. You can just mute the previews, but they would never start instantaneously. Also, this looks like a race condition waiting to occur where the video element is animating to the left when the user scrolls right. rect.right should be check as well.

@Informatic
Copy link
Member Author

I don't see any way of having a video reach any border of the screen during preview/scrolling the view, since it's always more-or-less centered, but sure - we can check that as well.

@kopiro
Copy link

kopiro commented Jan 8, 2023

Can we merge this? I've tested on my device and it also works perfectly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No preview "gif" of videos
3 participants