Don't send duplicate event on mouse click #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
throwaway96
force-pushed
the
fix-dup-click-evt-20240328
branch
from
cdc8ea6
to
dfb220b
Compare
On clicks, the YouTube app generates key events with keyCode 13 ("OK
button). We should not be sending our own click events for these, as
they already exist.
throwaway96
force-pushed
the
fix-dup-click-evt-20240328
branch
from
dfb220b
to
b62505d
Compare
throwaway96
added a commit
that referenced
this pull request
Mar 30, 2024
fire332
pushed a commit
to fire332/youtube-webos
that referenced
this pull request
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, the YouTube app generates key events with
keyCode13 (i.e., the "OK" button on webOS) when receives aclickevent.Usually, we do the reverse; that is, we cause a
clickon the element with focus when akeydownwithkeyCode13 is received. When such events are generated by the YouTube app, this leads to duplicate and incorrectly targetedclickevents.The
isTrustedproperty seems to provide a way to distinguish between events created by YouTube and WAM itself.Fixes #139.