Skip to content

Replaced webmozart/path-util dependency with @internal Path::isAbsolute() #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 5, 2022
Merged

Replaced webmozart/path-util dependency with @internal Path::isAbsolute() #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c96747f
Replaced `webmozart/path-util` dependency with `@internal` `Path::isA…
Ocramius Apr 5, 2022
1d7dbf7
Test on PHP 8.1 stable: it's been out for a while
Ocramius Apr 5, 2022
ca179c3
Updated all test dependencies to their latest & greatest
Ocramius Apr 5, 2022
4b355c9
Ensuring that windows paths are normalized, when running tests
Ocramius Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/phpunit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- "7.3"
- "7.4"
- "8.0"
- "8.1-rc"
- "8.1"
operating-system:
- "ubuntu-latest"
- "windows-latest"
Expand Down
12 changes: 3 additions & 9 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,19 +114,13 @@ $iterator = new GlobFilterIterator(

Relative globs such as `*.css` are not supported. Usually, such globs refer to
paths relative to the current working directory. This utility, however, does not
want to make such assumptions. Hence you should always pass absolute globs.

If you want to allow users to pass relative globs, I recommend to turn the globs
into absolute globs using the [Webmozart Path Utility]:
want to make such assumptions. Hence you should always pass absolute globs, so
usage of `__DIR__` is encouraged:

```php
use Webmozart\Glob\Glob;
use Webmozart\PathUtil\Path;

// If $glob is absolute, that glob is used without modification.
// If $glob is relative, it is turned into an absolute path based on the current
// working directory.
$paths = Glob::glob(Path::makeAbsolute($glob, getcwd());
$paths = Glob::glob(__DIR__ . '/*');
```

### Windows Compatibility
Expand Down
3 changes: 1 addition & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
}
],
"require": {
"php": "^7.3 || ^8.0.0",
"webmozart/path-util": "^2.2"
"php": "^7.3 || ^8.0.0"
},
"require-dev": {
"symfony/filesystem": "^5.3",
Expand Down
Loading