feat(cli-plugin-deploy-pulumi): add region to pulumi cli arguments #4523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrians5j
requested changes
Feb 6, 2025
There was a problem hiding this comment.
This whole file can be deleted I believe. @Pavel910 mentioned this to me some time ago.
packages/cli-plugin-deploy-pulumi/src/utils/env/withLogsForwardUrl.ts
Outdated
Show resolved
Hide resolved
packages/cli-plugin-deploy-pulumi/src/utils/env/withEnvVariant.ts
Outdated
Show resolved
Hide resolved
| @@ -51,6 +51,10 @@ export interface IUploadFolderToS3Params { | |||
| cacheControl?: PutObjectCommandInput["CacheControl"] | CacheControlMap; | |||
| } | |||
|
|
|||
| /** | |||
| * TODO @adrian | |||
There was a problem hiding this comment.
Dbl check with @Pavel910 if he's maybe using it somewhere or some user of his is maybe using it. Is it possible that this was just exposed for user consumption?
But yeah, could be a leftover.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add an option for user to deploy to a certain region, which is not necessarily the one in .env files.
Also removed the handler-logs usage from all packages.
Simple handler-logs package was left, otherwise the
yarn up "@webiny/*@5.43.x"would not work.How Has This Been Tested?
Manually.