Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Add fetch::missing::<resource-type> event #961

Closed
wants to merge 1 commit into from

Conversation

alrra
Copy link
Contributor

@alrra alrra commented Apr 2, 2018

Ref: #960

```ts
type FetchMissing {
/** The URL to download */
resource: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the resource is missing, I thing that most of the time we don't now the url/path

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to change this to /** The URL of the target. */.

Also:

  • resource this should be optional (for cases that do not have it)?
  • Maybe this should also include an element also optional for cases such as <link rel="manifest" href="">? Or should that be another case?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resource this should be optional (for cases that do not have it)?

I think so.

@alrra
Copy link
Contributor Author

alrra commented Apr 2, 2018

Talking a bit with @molant and @sarvaje, and we decided to see in the future how to better address this if we event have to (most of the time there will probably be just one rule that will use this event).


Note: I merged the improvements in c62ad58.

@alrra alrra closed this Apr 2, 2018
@alrra alrra deleted the add-fetch-missing-event branch April 2, 2018 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants