Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to types.ts #77

Closed
wants to merge 1 commit into from
Closed

Improvements to types.ts #77

wants to merge 1 commit into from

Conversation

molant
Copy link
Member

@molant molant commented Apr 4, 2017

  • Change file name to interfaces.ts
  • Split into multiple files under the interfaces folder
  • Rename interfaces to prepend I
  • Export all interfaces via interfaces.ts

Fixes #75

@molant
Improvements to types.ts
41278c5 
* Change file name to `interfaces.ts`
* Split into multiple files under the `interfaces` folder
* Rename interfaces to prepend `I`
* Export all interfaces via `interfaces.ts`

- - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fixes #75
@molant molant requested a review from alrra April 4, 2017 22:46
@molant
Copy link
Member Author

molant commented Apr 4, 2017

@alrra quite a few changes in here but they should be only about renames!

@alrra alrra closed this in a8f1f3f Apr 5, 2017
alrra pushed a commit that referenced this pull request Apr 5, 2017
@molant @alrra
Refactor and improve interfaces related code
9b1f8f5 
* Rename `types.ts` to `interfaces.ts`.
* Rename interfaces to start with `I`.
* Move interfaces into their own files under `interfaces/`.
* Export all interfaces via `interfaces.ts`.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix #75
Close #77
@molant molant deleted the fix-75 branch April 6, 2017 16:34
@snyk-bot snyk-bot mentioned this pull request Jul 17, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Sep 5, 2021
Open
@zelopy zelopy mentioned this pull request Jun 29, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jun 30, 2022
Open
@zelopy zelopy mentioned this pull request Nov 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alrra alrra Awaiting requested review from alrra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@molant