Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update Code of Conduct links #450

Merged
merged 1 commit into from
Aug 23, 2017
Merged

Conversation

kborchers
Copy link
Contributor

Link to CoC on JS Foundation website to ensure it is always up to
date and includes the full CoC including the committee,
enforcement details, etc.

Link to CoC on JS Foundation website to ensure it is always up to
date and includes the full CoC including the committee,
enforcement details, etc.
@alrra
Copy link
Contributor

alrra commented Aug 23, 2017

Link to CoC on JS Foundation website to ensure it is always up to

@kborchers How often is that changed?


See also: #353

@kborchers
Copy link
Contributor Author

kborchers commented Aug 23, 2017

@alrra It's not changed often, if ever, but we also don't track all of these other versions so if it does change, yours would be outdated. More importantly, the CoC includes a number of other pages with more information about the committee, enforcement of the code, etc that it is important people read as well so by linking directly to the JSF version, there is no question if people were given the full CoC to review.

@alrra
Copy link
Contributor

alrra commented Aug 23, 2017

@kborchers Maybe keep the CODE_OF_CONDUCT.md file and just add a link in it to https://js.foundation/community/code-of-conduct?

@kborchers
Copy link
Contributor Author

Not sure that's absolutely necessary since the CoC is linked in the README but if the team prefers that, I'm fine with it.

@alrra
Copy link
Contributor

alrra commented Aug 24, 2017

Not sure that's absolutely necessary since the CoC is linked in the README but if the team prefers that, I'm fine with it.

@sonarwhal/contributors ⬆️

@qzhou1607-zz
Copy link
Contributor

Linking directly seems okay to me when I first tried it out, but I'm not sure if it is best practice to link to pages in other domain from the navigation bar. Also if we do decide to link directly, maybe we can consider redirecting https://sonarwhal.com/about/code_of_conduct.html to https://js.foundation/community/code-of-conduct so that 404 won't show?

@alrra
Copy link
Contributor

alrra commented Aug 24, 2017

My concern: The CODE_OF_CONDUCT.md file has become something of a "standard" file and, like GitHub, I've seen other tools searching for it and signaling the lack of a code of conduct when they don't find it.

maybe we can consider redirecting https://sonarwhal.com/about/code_of_conduct.html to https://js.foundation/community/code-of-conduct so that 404 won't show?

Yes.

@alrra
Copy link
Contributor

alrra commented Aug 25, 2017

Also, when opening a new issue, now a user gets:

instead of:

@kborchers
Copy link
Contributor Author

I think getting the conduct link back is important so I would say we should add CODE_OF_CONDUCT.md back and in the file just say something like

The sonar project follows the JS Foundation Code of Conduct

@dmethvin
Copy link

That seems like the best solution to me as well. Any bots that want to see the file will be satisfied, but you won't have to duplicate the CoC.

alrra added a commit that referenced this pull request Aug 25, 2017
The `CODE_OF_CONDUCT.md` file has become something of a "standard",
being used by GitHub in a number of places, and possible other bots.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

¹ #353
  https://github.com/sonarwhal/sonar/community
  https://opensource.guide/code-of-conduct/

² #450 (comment)

Ref #450
Fix #450
@alrra
Copy link
Contributor

alrra commented Aug 25, 2017

I think getting the conduct link back is important so I would say we should add CODE_OF_CONDUCT.md back and in the file just say something like

The sonar project follows the JS Foundation Code of Conduct

That seems like the best solution to me as well. Any bots that want to see the file will be satisfied, but you won't have to duplicate the CoC.

Done in ca849a3.

@alrra
Copy link
Contributor

alrra commented Aug 26, 2017

Note: Also updated the other projects: 1, 2, and 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants