-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: Added Chrome Traces to cdp connector #420
Conversation
@axemclion Thanks for the PR! Can you sign the CLA? Thanks! |
Sorry, I think I sent the PR using a wrong account. I work for Microsoft. |
@panarasi you still need to sign the CLA. The code now belongs to the JS Foundation 😊 |
@panarasi the build is failing because of some |
Chrome Traces has much more information about performance and rules can use the new events - tracing::data and tracing::end for trace information. This information can be used for new rules like firstPaint, total time taken to parseHTML, long frames, rendering, etc.
@sarvaje Fixed eslint issues. |
In line 551, I am not using reject since the whole block is wrapped inside a |
|
||
}); | ||
debug(`Ending Collecting Chrome traces`); | ||
Tracing.end(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can Tracing.end
throw an exception? if so, you can wrap it in a try/catch
and call to reject
in the catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Tracing.end would throw just as Page.navigate or other chrome commands would. This just sends the command over to chrome over the protocol, so IMHO, it should be fine.
312b4e4
to
fcafcc9
Compare
4768e86
to
92c815c
Compare
34b45a1
to
c382d87
Compare
381d430
to
5e2be7f
Compare
620516f
to
dd7d250
Compare
406ab18
to
ec729e1
Compare
96ddafe
to
d9e263b
Compare
ae13787
to
88922a3
Compare
f5613b2
to
09aad7c
Compare
5573719
to
d57318c
Compare
Closing this as there's more work that needs to happen to enable it in all connectors but definitely something we want to add in the future. |
Chrome Traces has much more information about performance and
rules can use the new events - tracing::data and tracing::end
for trace information.
This information can be used for new rules like firstPaint,
total time taken to parseHTML, long frames, rendering, etc.