Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint-plugin-typescript to the latest version 🚀 #416

Closed

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Aug 9, 2017

Version 0.4.0 of eslint-plugin-typescript just got published.

Dependency eslint-plugin-typescript
Current Version 0.3.0
Type devDependency

The version 0.4.0 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of eslint-plugin-typescript.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.


Commits

The new version differs by 5 commits.

  • 0a781e9 Fix: type-annotation-spacing rule doesn't work for class properties (fixes #24) (#36)
  • ea18968 Fix: no-explicit-any Rule does not check generic type (fix #26) (#35)
  • cdd4073 New: no-use-before-define (#34)
  • 76860d6 New: Add rule member-ordering (#23)
  • d7b7936 New: Add rule no-type-literal (#15)

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

@molant
Copy link
Member

molant commented Aug 10, 2017

I've tried running this locally and it breaks the code if we use the --fix flag:

const questions = (inquirer.prompt as sinon.SinonStub).args[0][0];
const questions = (inquirer.promptas sinon.SinonStub).args[0][0];

const pageDOM = <IAsyncHTMLDocument>context.pageDOM;
const pageDOM =< IAsyncHTMLDocument>context.pageDOM;

and similar.

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Aug 12, 2017

Version 0.5.0 just got published.

Update to this version instead 🚀

Commits

The new version differs by 4 commits.

  • bae09be Chore: Publish version 0.5.0 to npm
  • e1eda2d New: Add adjacent-overload-signatures (#37)
  • cc4a362 Add typescript/no-unused-vars rule to documentation (#32)
  • c350de7 Chore: Publish version 0.4.0 to npm

See the full diff

@alrra
Copy link
Contributor

alrra commented Aug 13, 2017

I've tried running this locally and it breaks the code

There is an issue with type-annotation-spacing. I will remove it for the time being, and add some of the new rules.

@alrra alrra closed this in 75ea66d Aug 13, 2017
@greenkeeper greenkeeper bot deleted the greenkeeper/eslint-plugin-typescript-0.4.0 branch August 13, 2017 01:13
alrra added a commit that referenced this pull request Aug 13, 2017
@alrra alrra restored the greenkeeper/eslint-plugin-typescript-0.4.0 branch August 13, 2017 01:32
@alrra alrra reopened this Aug 13, 2017
@alrra alrra self-assigned this Aug 13, 2017
@alrra alrra closed this in 47e7d43 Aug 13, 2017
@alrra alrra deleted the greenkeeper/eslint-plugin-typescript-0.4.0 branch August 13, 2017 02:44
@alrra
Copy link
Contributor

alrra commented Aug 22, 2017

There is an issue with type-annotation-spacing. I will remove it for the time being, and add some of the new rules.

The issue was fixed. I'll add back type-annotation-spacing as part of #444.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants