-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rule to check the usage of charset meta tag #199
Conversation
const isHTMLDocument = (targetURL: string, responseHeaders: object) => { | ||
|
||
// If it's a local file, just presume it's a HTML document. | ||
// TODO: Change this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@molant When working with local files, rules will need a way to know what type of file they are dealing with.
(and I think this will became more important in the "text editor scenario")
Sending just the `Content-Type` HTTP header is in general ok, but it's | ||
usually a good idea to also add the charset meta tag because: | ||
|
||
* Server configurations might change (or servers might not send the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a trailing space in this line. The tests are failing because of this hehehe
@alrra I think this is one of those rules that should check the browserlist for some of it. As you say in the documentation, modern browsers alias |
My opinion is that we should stick to |
@molant Updated the docs. |
Fix #81