New: Checks if any SVG element is created using createElement()

[utsavized]

---

Fix #1625

Pull request checklist

Make sure you:

• Signed the Contributor License Agreement
• Followed the commit message guidelines

For non-trivial changes, please make sure you also:

• Added/Updated related documentation.
• Added/Updated related tests.

[antross]

So cool. 😎

No rush to address the feedback - I just wanted to get an initial review in while I had the time.

Enjoy your weekend!

[utsavized]

@antross @molant @sarvaje using eslint's result location did not work, as it sets line number to the beginning of the script tag and not the full source code. To solve that, I subscribed to the element::script event, and tried to use the script element's location to find the real problem location. However, I had some issues with element.getLocation() being null (I think because it is a promise and isn't resolved until the after the report call is made). So, used the findProblemLocation() function from location-helper to get position of the script element, then offset eslint's result location to be relative to the full source code. Not sure if this is the most optimal solution, but I am getting accurate line/col numbers now.

[molant]

I believe the issue with getLocation should be solved once #1943 gets merged (and if not we should make sure it is).

[sarvaje]

I believe the issue with getLocation should be solved once #1943 gets merged (and if not we should make sure it is).

Yep, that PR should solve the problem.

[molant]

that PR should solve the problem.

Then maybe we should try to get that one merged asap and update once it's done.

[antross]

Looking at the screenshot suggests the position is still off by a little bit as document is getting underlined instead of createElement...

[utsavized]

@antross Fixed.

[antross]

Functionally this looks great. 👍

Most of my comments are just opportunities to streamline the code a bit or improve wording in the documentation.

I also noticed one potential bug with external script references.

[utsavized]

@antross Does #1953 mean that I don't have the subscribe to element::script anymore, and have access to the element directly from ScriptParse object?

[utsavized]

@antross @molant @sarvaje PR Feedback addressed. Thanks!

[antross]

Looks good to me! 🎉

Thanks @utsavized for patiently keeping this PR up-to-date with our recent refactors.