Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Include PWA hints in configuration-development #1312

Closed
wants to merge 2 commits into from

Conversation

antross
Copy link
Member

@antross antross commented Sep 13, 2018

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

Includes disabling hint-manifest-exists so manifests are not
required, but will be validated if present.

Includes disabling `hint-manifest-exists` so manifests are not
required, but will be validated if present.
Copy link
Member

@molant molant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you exclude this configuration from the build process like the other ones? Otherwise LGTM

Aligns with the process for other configurations.
@alrra alrra closed this in 350ac03 Sep 14, 2018
@antross antross deleted the include-pwa-in-development branch September 14, 2018 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants