Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule sslabs check that endpoints exists #848

Closed
sarvaje opened this issue Mar 5, 2018 · 2 comments
Closed

Rule sslabs check that endpoints exists #848

sarvaje opened this issue Mar 5, 2018 · 2 comments
Assignees
@molant
Labels
priority:high type:bug type:technical-debt

Comments

@sarvaje
Copy link
Contributor

sarvaje commented Mar 5, 2018 •
edited
Loading

Sometimes, we get this error in the online scanner:

TypeError: Cannot read property 'endpoints' of undefined
online-service_worker-service.17.0jzbgue26ak8@swarm-worker000002    |     at end (/app/node_modules/sonarwhal/dist/src/lib/rules/ssllabs/ssllabs.js:94:23)
online-service_worker-service.17.0jzbgue26ak8@swarm-worker000002    |     at <anonymous>
online-service_worker-service.17.0jzbgue26ak8@swarm-worker000002    |     at process._tickCallback (internal/process/next_tick.js:160:7)

We should check if the property endpoints exists or not (maybe report a warning if it doesn't exists?)
@molant
Copy link
Member

molant commented Mar 12, 2018

We've had a similar error with html-checker. Need to find a good solution to not break when we use a third party service and document it

@molant
Copy link
Member

molant commented Mar 14, 2018

Actually the problem here is that host doesn't exist

@molant molant self-assigned this Mar 15, 2018
@molant molant mentioned this issue Mar 15, 2018
Closed
3 tasks
@alrra alrra closed this as completed in 9ba2581 Mar 15, 2018
alrra pushed a commit that referenced this issue Mar 15, 2018
@molant @alrra
Fix: Fail if response from ssllabs is empty
e45d4e8 
In some cases the `ssllabs` server returns an empty JSON
response with the status code 200 and that breaks things.

- - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix #848
Close #891
This was referenced Jan 12, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@molant molant

Labels
priority:high type:bug type:technical-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Fail if response from ssllabs is empty
2 participants
@molant @sarvaje