Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] no-broken-links#createReports should return only real promises in the array instead of Promise.resolve() #2034

Closed
molant opened this issue Mar 7, 2019 · 0 comments · Fixed by #4088

Comments

@molant
Copy link
Member

molant commented Mar 7, 2019

With the changes in #1943 there's a lot of code in createReports that returns Promise.resolve(). We should return only real Promises instead of doing that.
For that we could change return urls.map((url) => { to something like:

const requests: Promise<void>[] = [];
urls.forEach((url) => {
// magic here
requests.push(realPromiseToAdd);
}

return requests;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant